Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine layer metadata into single file #385

Conversation

crisner
Copy link
Contributor

@crisner crisner commented Feb 5, 2020

Fixes #371 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@crisner crisner changed the title Combine layer metadata into single file [WIP] Combine layer metadata into single file Feb 5, 2020
@crisner
Copy link
Contributor Author

crisner commented Feb 5, 2020

Because this involves changes in different parts of the project I feel it would be better to wait to merge this until LEL 2.2.0 is published so that we can contain the bugs if any within the LEL repo. However, this is ready for review. Thanks!

@crisner crisner changed the title [WIP] Combine layer metadata into single file Combine layer metadata into single file Feb 18, 2020
@crisner crisner requested a review from nstjean February 18, 2020 07:26
@crisner
Copy link
Contributor Author

crisner commented Feb 18, 2020

@nstjean, could you check if the layer menu is working as expected? Thanks!

@crisner
Copy link
Contributor Author

crisner commented Feb 18, 2020

Ah. Looks like some tests are failing. Shall take a look.

@crisner
Copy link
Contributor Author

crisner commented Feb 18, 2020

The test failed because we had changed the naming for the layers when combining the JSON files, which had affected the layer ids. Fixed.

@crisner crisner mentioned this pull request Feb 19, 2020
5 tasks
Copy link
Contributor

@nstjean nstjean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!! Works well for me!

@sagarpreet-chadha sagarpreet-chadha merged commit 4330a8e into publiclab:master Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine layer metadata into a single file
3 participants