Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List map tags in the view map page(new show page) #1050

Open
cesswairimu opened this issue Sep 25, 2019 · 5 comments · May be fixed by #1064

Comments

@cesswairimu
Copy link
Collaborator

commented Sep 25, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

Description

The new maps show page is slowly coming together, it would be nice to add the maps tags below the map...possibly in between embed and edit button

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  1. Change this line https://github.com/publiclab/mapknitter/blob/main/app/views/maps/show.html.erb#L10 to <div class="col-md-4">
  2. Change this line https://github.com/publiclab/mapknitter/blob/main/app/views/maps/show.html.erb#L16 to <div class="col-md-4">
  3. Immediately after this line https://github.com/publiclab/mapknitter/blob/main/app/views/maps/show.html.erb#L15 add this piece of code
<div class="col-md-4">
      <% @map.tags.each do |tag| %>
        <span id="tag_<%= tag.id %>" class="badge badge-light">
          <a href="/tags/<%= tag.name %>" id="tag_<%= tag.id %>"><%= tag.name %></a>
          <%= link_to([@map, tag], :method => "delete") do %>
            <span>&times;</span>
          <% end %>
        </span>
      <% end %>
</div>

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

$DIFF
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

Relevant URLs

http://mapknitter-stable.laboratoriopublico.org/maps/test

The page to be changed is https://github.com/publiclab/mapknitter/blob/main/app/views/maps/show.html.erb

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2019

@Lisa-Caton

This comment has been minimized.

Copy link

commented Oct 7, 2019

Hi there! I would like to claim this issue as a first-timer.

@cesswairimu

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 7, 2019

Hi @Lisa-Caton this is reserved for @nstjean, I will add your name to the list here
publiclab/plots2#6206 if you are looking for a first-timer issue. Thanks.

@Lisa-Caton

This comment has been minimized.

Copy link

commented Oct 7, 2019

Wonderful! Thank you.

@nstjean

This comment has been minimized.

Copy link

commented Oct 7, 2019

Thanks!

@nstjean nstjean referenced a pull request that will close this issue Oct 7, 2019
2 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.