Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage modal buttons not scaled #1174

Open
VladimirMikulic opened this issue Dec 25, 2019 · 9 comments · May be fixed by #1176
Open

Homepage modal buttons not scaled #1174

VladimirMikulic opened this issue Dec 25, 2019 · 9 comments · May be fixed by #1176

Comments

@VladimirMikulic
Copy link
Contributor

@VladimirMikulic VladimirMikulic commented Dec 25, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

🔥 Problem

Screenshot_20191225_171442

Screenshot_20191225_171519

On mobile phone and tablets, buttons are not of the same height.
It results in bad UI/UX and it should be fixed.

🚩 Solution

Screenshot_20191225_171912

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Open the file ./mapknitter/app/views/front_ui/index.erb

  • Line 55 -> add inline styles to paragraph

<p style="display:flex;justify-content:space-around;"><i style="color:#aaa;">A Community Atlas hosted by <a href="https://publiclab.org">PublicLab</a></i></p>
  • Line 64 -> add an inline style to the anchor tag
<a class="btn btn-primary btn-lg" style="display:flex;align-items:center;justify-content:center;" href="" data-toggle="collapse" data-target="#anonymous-map">
  • Line 66 -> add margin-left to inline styles
<i class="fa fa-plus fa-fw" style="font-size:12px;color:white;margin-left:2%;"></i>

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

$DIFF
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@Johongirrr

This comment has been minimized.

Copy link

@Johongirrr Johongirrr commented Dec 26, 2019

Hey @IshaGupta18 can I get this done?

@VladimirMikulic

This comment has been minimized.

Copy link
Contributor Author

@VladimirMikulic VladimirMikulic commented Dec 26, 2019

@Johongirrr of course, we would really appreciate your help with this issue.

@Johongirr

This comment has been minimized.

Copy link

@Johongirr Johongirr commented Dec 26, 2019

@VladimirMikulic Thank u I am on

@Johongirr

This comment has been minimized.

Copy link

@Johongirr Johongirr commented Dec 26, 2019

@VladimirMikulic problem was with height media queries need to be set up for this problem.

@media(min-width: 576px) and (max-width: 1359px){
p a.btn {
height: 80px;
}
}

@VladimirMikulic

This comment has been minimized.

Copy link
Contributor Author

@VladimirMikulic VladimirMikulic commented Dec 26, 2019

@Johongirr I would like you to follow the solution step by step. Your solution with media queries has it's flaws.

p a.btn would apply this style to all paragraphs that have anchors with btn class.

That's why I've done inline stylings, it is unique on the whole site, but it doesn't make sense to assign it an ID.

If there is anything that you didn't understand, feel free to ask :)

@Johongirr

This comment has been minimized.

Copy link

@Johongirr Johongirr commented Dec 26, 2019

Hi @VladimirMikulic sorry, I did not look at the code you provided. i looked at picture and figured that problem is with height either coz modal buttons were not given same height or elements nested inside them had

@VladimirMikulic

This comment has been minimized.

Copy link
Contributor Author

@VladimirMikulic VladimirMikulic commented Dec 26, 2019

@Johongirr it's alright, no need to apologise!
It's the important thing for newcomers to understand why we do something instead of what we do.

I would love a PR from you that resolves this 🚀

@Johongirr

This comment has been minimized.

Copy link

@Johongirr Johongirr commented Dec 26, 2019

@VladimirMikulic I made my PR and now wating for review and approval of it.

@VladimirMikulic

This comment has been minimized.

Copy link
Contributor Author

@VladimirMikulic VladimirMikulic commented Dec 26, 2019

@Johongirr great work, I've approved the task, but please specify this issue number #1174 in your PR description. Thanks.

@Johongirr Johongirr linked a pull request that will close this issue Dec 26, 2019
5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.