Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use secure url link on image upload modal #1675

Closed
5 tasks
PeculiarE opened this issue Apr 26, 2022 · 10 comments · Fixed by PrajwalBorkar/mapknitter#1 or #1676
Closed
5 tasks

Use secure url link on image upload modal #1675

PeculiarE opened this issue Apr 26, 2022 · 10 comments · Fixed by PrajwalBorkar/mapknitter#1 or #1676

Comments

@PeculiarE
Copy link
Contributor

Hi, this is a first-timers-only issue and this means we have worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Claim the issue by commenting. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
💡 Learn how to claim 🙋

Claiming an issue

Unless the issue is marked as reserved for someone, you can just say "I'd like to try this!" and then you've claimed it - no need to wait for someone to assign it to you. Just be sure you link your pull request (PR) to this issue so we can see where your solution is.

And open one early if possible - even before you've completed it with additional commits - and others can help you figure out any issues you may face.

  • 📝 Update the file _new.html.erb in the mapknitter repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -113,7 +113,7 @@
         </button>
         <hr />
         <p>
-          Where can you get images to upload?<br />Take them from an airplane window, or read about <a href="http://publiclab.org/wiki/Balloonslloons-mapping">Grassroots Mapping with Balloons and Kites</a>.
+          Where can you get images to upload?<br />Take them from an airplane window, or read about <a target="_blank" href="https://publiclab.org/wiki/balloon-mapping">Grassroots Mapping with Balloons and Kites</a>.
         </p>
       </div>
     </div>
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below, and reach out in our chatroom!

@PeculiarE
Copy link
Contributor Author

Hi @TildaDares, @jywarren, @cesswairimu...Please help review for a possible FTO issue. Thank you!

@cesswairimu cesswairimu changed the title FTO: Fix wrong link on image upload modal Use secure url link on image upload modal Apr 26, 2022
@cesswairimu
Copy link
Collaborator

This is great @PeculiarE, thanks a lot for opening this ❤️

@shefali12-ab
Copy link

Hey @cesswairimu i have worked on FTO issue before, can I work on this FTO also.

@cesswairimu
Copy link
Collaborator

Hi @shefali12-ab , we usually leave these ones for first time contributors...I could try get a non-fto issue if you are interested :)

@shefali12-ab
Copy link

sure @cesswairimu I am interested to work on the non-FTO issue.

@PrajwalBorkar
Copy link
Contributor

Can I work on this @cesswairimu ?

@cesswairimu
Copy link
Collaborator

Go ahead @PrajwalBorkar , thanks. Great @shefali12-ab , I will ping you once I find one, thanks

@PeculiarE
Copy link
Contributor Author

This is great @PeculiarE, thanks a lot for opening this ❤️

😄 ❤️ ...Thank you for reviewing it @cesswairimu

PrajwalBorkar added a commit to PrajwalBorkar/mapknitter that referenced this issue Apr 26, 2022
PrajwalBorkar added a commit to PrajwalBorkar/mapknitter that referenced this issue Apr 26, 2022
@PrajwalBorkar
Copy link
Contributor

Please review the PR and check if any changes are required.
Thanks.

@Somya-Singhal
Copy link

Hello @cesswairimu, I would also like to try a non-fto issue.

cesswairimu pushed a commit that referenced this issue May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants