New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RSS feed to properly include images #248

Open
jywarren opened this Issue Jan 17, 2018 · 23 comments

Comments

Projects
None yet
7 participants
@jywarren
Contributor

jywarren commented Jan 17, 2018

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

The problem

What's supposed to happen: MapKnitter maps in the "clean" feed are supposed to be tweeted out at http://twitter.com/mapknitter

But the images are all broken!

Solution

This was recently completed on PublicLa.org in this issue:

publiclab/plots2#1958

Let's reproduce those fixes here, noting especially the final version of the RSS feed, here:

https://github.com/sagarpreet-chadha/plots2/blob/b866d864eba05f0c9316cdac505493d8e60e75e9/app/views/notes/rss.rss.builder#L1-L25

The corresponding MapKnitter code is here:

xml.instruct!
xml.rss "version" => "2.0", "xmlns:dc" => "http://purl.org/dc/elements/1.1/" do
xml.channel do
xml.title "Recent maps at MapKnitter.org"
xml.link url_for :only_path => false, :controller => 'spectrums'
xml.description "Recently posted maps at MapKnitter.org, a Public Lab open source research initiative"
@maps.each do |map|
xml.item do
xml.title map.name
xml.author map.author
xml.pubDate map.created_at.to_s(:rfc822)
xml.category "mapknitter"
xml.image map.warpables.first.image.url(:medium)
xml.link "https://mapknitter.org/maps/"+map.slug
xml.description map.description.to_s + " " + map.warpables.first.image.url(:medium)
xml.guid "https://mapknitter.org/maps/"+map.slug
end
end
end
end

Note especially this line, which inserts the image correctly into the post:

https://github.com/sagarpreet-chadha/plots2/blob/b866d864eba05f0c9316cdac505493d8e60e75e9/app/views/notes/rss.rss.builder#L12

That's the most important line to add into the MapKnitter feed!

Steps to Fix

  • claim this issue with a comment here, below, and ask any clarifying questions you need
  • set up a repository locally following the README instructions, and make sure that all tests pass
  • try to fix the issue following the steps above, but even before you're done, you can:
  • commit your changes and start a pull request (see contributing to Public Lab software) but mark it as "in progress" if you have questions or if you haven't finished
  • alert someone via the developers list (see below) to have your pull request merged. This may take a few extra steps depending on when you do it, but we'll help you out!

Please email the developers list (see https://publiclab.org/wiki/developers) or go to the chatroom if you have questions, and take a look at our first-timers landing page for more information!

(This is a follow-up to old issue here: #241)

@anyangocynthia

This comment has been minimized.

anyangocynthia commented Jan 17, 2018

Hey, I would like to work on this

@jywarren

This comment has been minimized.

Contributor

jywarren commented Jan 17, 2018

@jywarren

This comment has been minimized.

Contributor

jywarren commented Jan 18, 2018

Hi, just checking in -- this didn't quite work on PublicLab.org, and we ended up making one more addition with the image -- this line: https://github.com/publiclab/plots2/pull/2043/files

Hope that helps! And I hope it works for PublicLab.org too - i'm just waiting for our test to complete for it :-)

@jywarren

This comment has been minimized.

Contributor

jywarren commented Feb 4, 2018

Ok! We got this working on PublicLab.org now and the latest RSS template there is correct.

https://github.com/publiclab/plots2/blob/master/app/views/notes/rss.rss.builder

How are you doing on this one? Need some help?

@jywarren

This comment has been minimized.

Contributor

jywarren commented Mar 12, 2018

This is up for grabs if folks want to give it a try, thank you!

@kuangmichael07

This comment has been minimized.

kuangmichael07 commented Jul 11, 2018

Hi @jywarren ,
As a new comer, I would love to give it a try

@jywarren

This comment has been minimized.

Contributor

jywarren commented Jul 11, 2018

@kuangmichael07

This comment has been minimized.

kuangmichael07 commented Jul 12, 2018

@jywarren Hi Jeff,
I am running trying to do the prerequisite on iOS and replace apt-get by brew but the terminal returns: Running Homebrew as root is extremely dangerous and no longer supported.
As Homebrew does not drop privileges on installation you would be giving all
build scripts full access to your system.

Do you have a video for setting up this on iOS? I am a js developer and not familiar with Ruby so ran into lots of issues

Thanks for the help

@jywarren

This comment has been minimized.

Contributor

jywarren commented Jul 12, 2018

@jywarren

This comment has been minimized.

Contributor

jywarren commented Jul 23, 2018

Hi, just checking if you've gotten stuck on this at all, or if I could help in any way? Thanks!

@kuangmichael07

This comment has been minimized.

kuangmichael07 commented Jul 24, 2018

Hi @jywarren Jeff, I am still working on this. Will let you know about the progress later today

@jywarren

This comment has been minimized.

Contributor

jywarren commented Jul 24, 2018

@aashnajena

This comment has been minimized.

aashnajena commented Aug 12, 2018

Hi,
I'd like to work on this issue as a first-time contributor. Is this issue already resolved or can i take it up?

@jywarren

This comment has been minimized.

Contributor

jywarren commented Aug 12, 2018

@14Richa

This comment has been minimized.

14Richa commented Sep 30, 2018

Taking a look! Thanks for pointing this out

@jywarren

This comment has been minimized.

Contributor

jywarren commented Oct 1, 2018

@vanguard07

This comment has been minimized.

vanguard07 commented Oct 3, 2018

I would like to work on this. Is the issue still open?

@jywarren

This comment has been minimized.

Contributor

jywarren commented Oct 3, 2018

Is @14Richa still working on it? If not, you could go ahead, but if so, maybe you can offer them some help?

@14Richa

This comment has been minimized.

14Richa commented Oct 3, 2018

@sk9331657

This comment has been minimized.

sk9331657 commented Oct 7, 2018

@jywarren I can fix this today. Can I work on it??

@jywarren

This comment has been minimized.

Contributor

jywarren commented Oct 8, 2018

@14Richa

This comment has been minimized.

14Richa commented Oct 9, 2018

@jywarren

This comment has been minimized.

Contributor

jywarren commented Oct 22, 2018

Hi, just checking if you've gotten stuck on this at all, or if I could help in any way? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment