Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Replace Login button with PL icon #559
Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.
If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!
We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you
If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!
Code link: app/views/layout/_login_form.html.erb
After changes login button in the drop down should be replaced with
It should look like this -
If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.
If this happens to you, don't sweat it! Grab another open issue.
Is someone else already working on this?
referenced this issue
Apr 22, 2019
yeah, best of luck…
On Mon, Apr 22, 2019 at 8:19 PM stevenks17 ***@***.***> wrote: I am still a bit new to Github and HTML I just want to make sure I am understanding the issue. I should be replacing the dropdown login icon with the PL Icon? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#559 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFAAEQ43BYRQASHJ5KEXEDDPRXGADANCNFSM4HHOPT4A> .
Hey @SidharthBansal, I think it will be better to put pl icon in the input field. The icon itself is smaller for to be a button, and it didn't have tranparent background in order to put inside the blue login button.
I've also fix the z-index problem between quick login form and leaflet's control layers. What do you think?
Please check the latest master. Your changes are outdated. Thanks…
On Tue, May 14, 2019 at 11:30 PM umuur ***@***.***> wrote: Hi there, I think it will be better to put pl icon in the input field. The icon itself is smaller for to be a button, and it didn't have tranparent background in order to put inside the blue login button. [image: Screenshot from 2019-05-14 20-43-16] <https://user-images.githubusercontent.com/8915912/57720739-22546a00-768b-11e9-84f4-eb045fd173c0.png> [image: Screenshot from 2019-05-14 20-43-28] <https://user-images.githubusercontent.com/8915912/57720740-22ed0080-768b-11e9-80dc-17d176354b91.png> I've also fix the z-index problem between quick login form and leaflet's control layers. What do you think? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#559?email_source=notifications&email_token=AFAAEQ6SUCWUII7OXLCDFEDPVL42FA5CNFSM4HHOPT4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVMJIAA#issuecomment-492344320>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFAAEQ2PHYBFWOVQBGGQW7DPVL42FANCNFSM4HHOPT4A> .