Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Login button with PL icon #559

Open
SidharthBansal opened this issue Apr 22, 2019 · 12 comments

Comments

Projects
None yet
3 participants
@SidharthBansal
Copy link
Member

commented Apr 22, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.
Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step
🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

📝 Update
Replace Login button with PL icon

Code link: app/views/layout/_login_form.html.erb

Earlier

image

After changes login button in the drop down should be replaced with

It should look like this -

image

💾 Commit your changes

🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

You can also edit files directly in your browser and open a pull request from there.

🏁 Done Ask in comments for a review :)
Please keep us updated
💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?
🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?
Leave a comment below!
Part of #381

@stevenks17

This comment has been minimized.

Copy link

commented Apr 22, 2019

Claimed

@stevenks17

This comment has been minimized.

Copy link

commented Apr 22, 2019

I am still a bit new to Github and HTML I just want to make sure I am understanding the issue. I should be replacing the dropdown login icon with the PL Icon?

@SidharthBansal

This comment has been minimized.

Copy link
Member Author

commented Apr 22, 2019

@SidharthBansal

This comment has been minimized.

Copy link
Member Author

commented Apr 27, 2019

Hi, how is it going on?

@umuur

This comment has been minimized.

Copy link

commented Apr 28, 2019

Is @stevenks17 still looking at this?

@SidharthBansal

This comment has been minimized.

Copy link
Member Author

commented May 12, 2019

@umuur I think they busy with something else.
@umuur please take it if you wish to do so.
Sorry for late reply.

@umuur

This comment has been minimized.

Copy link

commented May 14, 2019

on it.

@umuur

This comment has been minimized.

Copy link

commented May 14, 2019

Hey @SidharthBansal, I think it will be better to put pl icon in the input field. The icon itself is smaller for to be a button, and it didn't have tranparent background in order to put inside the blue login button.

Screenshot from 2019-05-14 20-43-16
Screenshot from 2019-05-14 20-43-28

I've also fix the z-index problem between quick login form and leaflet's control layers. What do you think?

@SidharthBansal

This comment has been minimized.

Copy link
Member Author

commented May 15, 2019

@umuur

This comment has been minimized.

Copy link

commented May 15, 2019

Hi Sidharth, does the demo link points the latest master? Could you please send me the screenshots about what should be achieved?

@SidharthBansal

This comment has been minimized.

Copy link
Member Author

commented May 15, 2019

Hi my name is Sidharth.
Please make the login modal of mapknitter.org/login similar to login modal of spectralworkbench.org/login.

Yes, there are major changes in the master.

@SidharthBansal

This comment has been minimized.

Copy link
Member Author

commented May 15, 2019

Thanks for asking @umuur

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.