Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Leaflet FullHash object for dynamic URL #621

Open
sagarpreet-chadha opened this issue May 20, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@sagarpreet-chadha
Copy link
Contributor

commented May 20, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.
Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step
🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

📝 Update

We have added leaflet-fullHash library in the bower and included the link to this library on the index page .

Let's add leaflet-fullHash object which makes the URL dynamic in accordance to selected layers of the map .

Add this lines of code after this line

in index.html.erb :

var allMapLayers = {
      "BL1": baselayer1,
      "Purple": PurpleAirMarkerLayer,
      "STruth": SkyTruth,
      "FracTL": Fractracker,
      "ToxicR": ToxicRelease,
      "OdorR": OdorReport,
      "MapK": MapKnitter,
      "OIMPower": OpenInfraMap_Power ,
      "OIMapTelecom": OpenInfraMap_Telecom ,
      "OIMPetroleum": OpenInfraMap_Petroleum ,
      "OIMWater": OpenInfraMap_Water ,
      "JMincome": Justicemap_income,
      "JMamericanIndian": JusticeMap_americanIndian ,
      "JMasian": JusticeMap_asian ,
      "JMblack": JusticeMap_black,
      "JMmulti": JusticeMap_multi ,
      "JMhispanic": JusticeMap_hispanic ,
      "JMnonWhite": JusticeMap_nonWhite,
      "JMwhite": JusticeMap_white ,
      "JMplurality": JusticeMap_plurality ,
      "Clouds": clouds ,
      "cloudsclassic": cloudscls ,
      "precipitation": precipitation ,
      "precipcls": precipitationcls ,
      "rain": rain ,
      "raincls": raincls ,
      "snow": snow ,
      "pressure": pressure ,
      "pressurecontour": pressurecntr ,
      "temp": temp ,
      "wind": wind ,
      "Cities": city  ,
      "windrose": windrose 
    };

    var hash = new L.Hash(Mapknitterunique, allMapLayers);

💾 Commit your changes

🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

You can also edit files directly in your browser and open a pull request from there.

🏁 Done Ask in comments for a review and also add a screenshot of the address bar of browser showing URL :)

Please keep us updated
💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?
🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?
Leave a comment below!

Part of #510 :)

@sashadev-sky

This comment has been minimized.

Copy link
Collaborator

commented May 20, 2019

assigned to @konolga!

@divyanshu29

This comment has been minimized.

Copy link

commented Jun 10, 2019

Is the issue still open? Can i contribute still?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.