Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cursor to pointer #639

Open
divyabaid16 opened this issue May 27, 2019 · 9 comments

Comments

Projects
None yet
3 participants
@divyabaid16
Copy link
Contributor

commented May 27, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update

Selection_162

Changes: Chance cursor to pointer download and pan to this image
Make changes in file app/views/images/_index.html.erb Change

<a rel="tooltip" id="locate-warpable-<%= warpable.id %>" title="Pan to this image" class="btn btn-sm btn-success"><i class='fa fa-crosshairs'></i></a>

<a rel="tooltip" title="Download full resolution distorted image (please allow popups)" class="btn btn-sm btn-outline-secondary img-download img-download-<%= warpable.id %>" data-image="/images/fetch/?url=<%= warpable.image.url(:original) %>"><i class="fa fa-download"></i></a>

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@zelol

This comment has been minimized.

Copy link

commented Jun 19, 2019

Still open for first-timer? :)

@divyabaid16

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2019

Yes @zelol you can work on this.
Thanks!

@joreneng

This comment has been minimized.

Copy link

commented Jun 26, 2019

Hi, is this still open?

@divyabaid16

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

@zelol are you working on this?

@zelol

This comment has been minimized.

Copy link

commented Jun 26, 2019

@divyabaid16 Oops I forgot. I will work on it immediately. Sorry again.

@divyabaid16

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

Go ahead on solving this @zelol
And we will create another issue for you @joreneng
Thanks!

@zelol

This comment has been minimized.

Copy link

commented Jun 26, 2019

@divyabaid16 Seems that it requires various installation and I honestly do not have the time right now.
I cannot work on it this week, too. I'll leave my place to @joreneng. Sorry again.

@divyabaid16

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

No problem @zelol you can try some other time.
@joreneng would you like to work on this now?
Thanks!

@joreneng

This comment has been minimized.

Copy link

commented Jun 26, 2019

@divyabaid16 I'll work on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.