Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live editing switch for synchronous editing ability #943

Open
ViditChitkara opened this issue Aug 15, 2019 · 6 comments

Comments

@ViditChitkara
Copy link
Member

commented Aug 15, 2019

This is a part of #893

Screenshot 2019-07-30 at 11 52 45 PM

A live editing switch is required somewhere on the sidebar. It could be something like:-

image
The purpose of this switch is the ability make the map editable by other users connected to the map.

I've started with #937 . Maybe we could extend that accordingly.

We can use the toggle_editing route to save the map creator's preference there.

@ViditChitkara

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2019

@ViditChitkara

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2019

We may also take some hints from #381 for the enable/disable apis.

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

@ViditChitkara

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2019

Yes, I think that makes sense. So in total we'll have two switches one for "allow others to edit this map" which will make use of the added column in map table. And the other would simply be "allow real-time-editing". The later would require an extra layer of authentication at connection.rb to stop others from editing the map -- probably by rejecting their connection to the channel -- the same way we do for a user who is not logged in. Does that make any sense?
Also, do you want me to code this or should this remain a first timer only issue?

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

@ViditChitkara

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2019

Great!! I'll get started with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.