Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add border to Authors in gallery template #965

Open
divyabaid16 opened this issue Aug 25, 2019 · 4 comments

Comments

@divyabaid16
Copy link
Contributor

commented Aug 25, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update

Selection_246

In https://mapknitter.org/gallery "Authors" tab, sometimes when the image is completely white, it becomes difficult to distinguish the image from the gallery template. So add a border here.
After this line add

border: 1px solid #ddd;

To get help installing the application on your computer, see the project README and get help at #307

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

$DIFF
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@Sravanksk

This comment has been minimized.

Copy link

commented Aug 25, 2019

Hello @divyabaid16 Can I take this ?

@divyabaid16

This comment has been minimized.

Copy link
Contributor Author

commented Aug 25, 2019

Ya go ahead @Sravanksk

@Sravanksk

This comment has been minimized.

Copy link

commented Aug 25, 2019

Yeah , Thank you.

nickycutesc added a commit to nickycutesc/mapknitter that referenced this issue Aug 25, 2019
Add border to Authors in gallery template publiclab#965
First Timers is awesome! Added a border for issue publiclab#965
@TantumErgo

This comment has been minimized.

Copy link

commented Sep 4, 2019

@divyabaid16 Is this issue still open? I took a look at the pull request, but it was left unfinished 8 days ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.