New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapKnitter refactoring #22

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@justinmanley
Contributor

justinmanley commented Aug 29, 2014

Upgrades to MapKnitter done as part of Google Summer of Code.

Roadmap

Backend

  • Give resources human-readable permalinks / urls using friendly_id
  • Make sure that the author field is filled when a map is created (it's currently being set to anonymous, even when authenticated users create maps).
  • Uploads are failing 2/3 of the time (from Mathew's comment).
  • Tags aren't saving (from @lotelx's comment). [Fixed by 1dde729].
  • Add server-side validations to Annotation model.

Style

  • Move sidebar scrollbar to the far right side of the page and add left padding to sidebar scrollbar.
  • "Create Map" button gets lost below the bottom of the sidebar (from Liz's comment). [Fixed by e22b793].

Annotations

  • Give Leaflet.Illustrate objects a toGeoJson method and update MapKnitter Annotation model to accomodate both Leaflet.Illustrate and Leaflet.Draw annotations.
  • Add ability to change the color of annotations.
  • Tie text to the map scale.
  • Enable users to bind popups to polylines, polygons, and circles.

Integration

UI / UX

  • "Can't figure out how to place images at all." - Need to make clear to users what the next step is after uploading an image (from Mathew's comment). Users expect to see images on the map as soon as they are uploaded (from @lotelx's comment).
  • Add Google Maps-style searching OR allow users to click on the map to pick the map location OR allow users to upload an image to determine the map location (or all three) (from Mathew's comment).
  • Add button to center the view on the map (from Mathew's comment and @lotelx's comment).
@lotelx

This comment has been minimized.

Show comment
Hide comment
@lotelx

lotelx Sep 2, 2014

Thanks for the great work.

All tests in Android 4.4 (Chrome):

  • Not a problem but when creating a new map with default coordinates 0,0 the level of the zoom is also the maximum, this confuse a bit for new users because the screen is black (ocean) and they need to zoom out a lot for see the world. Maybe the deault zoom should be a image when we can see the hole world.
  • If I not save the map I can not move the map with one finger.

*Using two fingers sometimes the map makes a jump to another place. And always make zoom in or zoom out even if i don't move the fingers. This confuse a bit.

  • Also doing zoom with two fingers, when I release the fingers always makean extra zoom in or out, so it's complicate to adjust exactly to the desirable level of zoom of the user, the zoom is in steps and not pregressive.
  • It looks like the tags don't save.
  • I miss a button for center the coordinates of the map here.
  • After uploading a image, it uploads correctly, but nothing happens, i can not see the image onthe map.
  • The buttons on the right side are empty.

lotelx commented Sep 2, 2014

Thanks for the great work.

All tests in Android 4.4 (Chrome):

  • Not a problem but when creating a new map with default coordinates 0,0 the level of the zoom is also the maximum, this confuse a bit for new users because the screen is black (ocean) and they need to zoom out a lot for see the world. Maybe the deault zoom should be a image when we can see the hole world.
  • If I not save the map I can not move the map with one finger.

*Using two fingers sometimes the map makes a jump to another place. And always make zoom in or zoom out even if i don't move the fingers. This confuse a bit.

  • Also doing zoom with two fingers, when I release the fingers always makean extra zoom in or out, so it's complicate to adjust exactly to the desirable level of zoom of the user, the zoom is in steps and not pregressive.
  • It looks like the tags don't save.
  • I miss a button for center the coordinates of the map here.
  • After uploading a image, it uploads correctly, but nothing happens, i can not see the image onthe map.
  • The buttons on the right side are empty.
@justinmanley

This comment has been minimized.

Show comment
Hide comment
@justinmanley

justinmanley Sep 8, 2014

Contributor

@lotelx Thanks for the feedback. I've added everything I think is a MapKnitter issue to the todo list at the top. I think your issue with two-fingered zooming, tapping, etc., may be an issue with Leaflet (the mapping library we're using), so I'm going to shelve that for the time being.

I'm curious about your comment that "The buttons on the right side are empty." The icons for those buttons are set via CSS, and that's it, so I'm not sure what's going wrong there... As I keep updating and doing more tests, I'll keep an eye out.

Thanks for testing on Android, BTW! I haven't tried it at all on mobile yet, so I'm glad someone is!

Contributor

justinmanley commented Sep 8, 2014

@lotelx Thanks for the feedback. I've added everything I think is a MapKnitter issue to the todo list at the top. I think your issue with two-fingered zooming, tapping, etc., may be an issue with Leaflet (the mapping library we're using), so I'm going to shelve that for the time being.

I'm curious about your comment that "The buttons on the right side are empty." The icons for those buttons are set via CSS, and that's it, so I'm not sure what's going wrong there... As I keep updating and doing more tests, I'll keep an eye out.

Thanks for testing on Android, BTW! I haven't tried it at all on mobile yet, so I'm glad someone is!

@jywarren jywarren closed this Jan 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment