Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Rails 6.0.0 #824

Open
wants to merge 36 commits into
base: development
from
Open

Upgrade to Rails 6.0.0 #824

wants to merge 36 commits into from

Conversation

@alaxalves
Copy link
Member

alaxalves commented Jul 9, 2019

Fixes #603 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/mapknitter-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@alaxalves

This comment has been minimized.

Copy link
Member Author

alaxalves commented Jul 9, 2019

In order to get this running we'll need a ruby version > 2.5. What's your input on this? @sashadev-sky @jywarren

@jywarren

This comment has been minimized.

Copy link
Contributor

jywarren commented Jul 9, 2019

@jywarren

This comment has been minimized.

Copy link
Contributor

jywarren commented Jul 9, 2019

@alaxalves

This comment has been minimized.

Copy link
Member Author

alaxalves commented Jul 9, 2019

Ah, interesting. Would upgrading to Ruby 2.5 be its own PR perhaps, that could be done before Rails 6?

On Tue, Jul 9, 2019 at 12:12 PM Jeffrey Warren @.> wrote: Hi @alaxalves - @icarito noted that Rails 6 is currently beyond Debian stable's version, and i was wondering if we should start with a PR that addresses deprecations and warnings without actually initiating the 6.0 upgrade just yet. Do we have an idea of Debian stable's schedule? I just want to be careful about this and think well ahead, and I don't quite have all the info to provide good input yet. Thanks so much! On Tue, Jul 9, 2019 at 12:08 PM 脕lax de Carvalho Alves < @.> wrote: > Fixes #603 <#603> (<=== > Add issue number here) > > Make sure these boxes are checked before your pull request (PR) is ready > to be reviewed and merged. Thanks! > > - PR is descriptively titled and links the original issue above > - tests pass -- look for a green checkbox a few minutes after > opening your PR -- or run tests locally with rake test > - code is in uniquely-named feature branch and has no merge conflicts > > - screenshots/GIFs are attached in case of UI updation > - ask @publiclab/mapknitter-reviewers for help, in a comment below > > We're happy to help you get this ready -- don't be afraid to ask for > help, and don't be discouraged if your tests fail at first! > > If tests do fail, click on the red X to learn why by reading the logs. > > Please be sure you've reviewed our contribution guidelines at > https://publiclab.org/contributing-to-public-lab-software > > Thanks! > ------------------------------ > You can view, comment on, or merge this pull request online at: > > #824 > Commit Summary > > - Bumping rails version > > File Changes > > - M Gemfile > https://github.com/publiclab/mapknitter/pull/824/files#diff-0 (4) > - M Gemfile.lock > https://github.com/publiclab/mapknitter/pull/824/files#diff-1 (131) > > Patch Links: > > - https://github.com/publiclab/mapknitter/pull/824.patch > - https://github.com/publiclab/mapknitter/pull/824.diff > > 鈥 > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#824?email_source=notifications&email_token=AAAF6J6XGCTGN7NXDOO4KJTP6SZWVA5CNFSM4H7HD3Y2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G6ESRFQ>, > or mute the thread > https://github.com/notifications/unsubscribe-auth/AAAF6J7RBR5CLPG4LNUPQFLP6SZWVANCNFSM4H7HD3YQ > . >

Yes, I could open a MR upgrading to latest ruby. BTW can I push Rails 5 to unstable?

@jywarren

This comment has been minimized.

Copy link
Contributor

jywarren commented Jul 9, 2019

@alaxalves alaxalves force-pushed the rails-6 branch from dca3f90 to e5b3320 Jul 11, 2019
alaxalves added 3 commits Jul 11, 2019
@alaxalves alaxalves force-pushed the rails-6 branch from 06cea37 to 511f339 Jul 11, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jul 11, 2019

Codecov Report

Merging #824 into development will decrease coverage by 23.26%.
The diff coverage is 75%.

Impacted file tree graph

@@               Coverage Diff                @@
##           development     #824       +/-   ##
================================================
- Coverage        74.03%   50.77%   -23.27%     
================================================
  Files               40       40               
  Lines             1398     1426       +28     
================================================
- Hits              1035      724      -311     
- Misses             363      702      +339
Impacted Files Coverage 螖
lib/extensions/action_view/helpers.rb 0% <酶> (酶) 猬嗭笍
lib/extensions.rb 0% <酶> (酶) 猬嗭笍
lib/extensions/action_view.rb 0% <酶> (酶) 猬嗭笍
...extensions/action_view/helpers/asset_tag_helper.rb 0% <0%> (酶) 猬嗭笍
app/models/map.rb 55.48% <100%> (-38.07%) 猬囷笍
app/controllers/comments_controller.rb 100% <100%> (酶) 猬嗭笍
app/controllers/maps_controller.rb 93.16% <100%> (酶) 猬嗭笍
lib/exporter.rb 0% <0%> (-94.18%) 猬囷笍
app/models/annotation.rb 53.33% <0%> (-46.67%) 猬囷笍
... and 9 more
@alaxalves alaxalves force-pushed the development branch from 426e072 to 85f54a5 Jul 11, 2019
@alaxalves alaxalves force-pushed the development branch 2 times, most recently from 8e9fd3f to 2abced6 Jul 15, 2019
@@ -5,7 +5,7 @@
//= require blueimp-file-upload/js/jquery.fileupload-ui

// iframe-transport is ajax file upload support for IE, Uncomment if needed
// javascript_include_tag (file_upload + "js/jquery.iframe-transport")
// javascript_pack_tag (file_upload + "js/jquery.iframe-transport")

This comment has been minimized.

Copy link
@kaustubh-nair

kaustubh-nair Jul 19, 2019

Collaborator

This is not working.
I get ActionView::Template::Error: undefined method javascript_pack_tag'`

This comment has been minimized.

Copy link
@alaxalves

alaxalves Jul 19, 2019

Author Member

I know, the webpacker integration is not working.

This comment has been minimized.

Copy link
@kaustubh-nair

kaustubh-nair Jul 20, 2019

Collaborator

There's a problem with the installation itself. The rake task doesn't work after adding webpacker to the gemfile.

@alaxalves alaxalves force-pushed the rails-6 branch from 8da5681 to c730a0b Aug 20, 2019
@alaxalves alaxalves changed the title WIP: Updating Mapknitter to Rails 6.0.0 Upgrade to Rails 6.0.0 Aug 20, 2019
@alaxalves alaxalves requested review from jywarren, sashadev-sky and icarito Aug 20, 2019
@alaxalves alaxalves added the ready label Aug 20, 2019
@alaxalves alaxalves added this to the Rails Upgrade milestone Aug 20, 2019
@jywarren

This comment has been minimized.

Copy link
Contributor

jywarren commented Aug 20, 2019

Hi, @alaxalves -- this is so exciting! Did you have a chance to look into the Debian Rails 6 schedule, or do some thinking/planning on the potential issues related to getting ahead of Debian? Let's also ping @icarito on this topic!

@alaxalves

This comment has been minimized.

Copy link
Member Author

alaxalves commented Aug 20, 2019

@icarito @jywarren According to this link they have only mapped the upcoming functionalities for Rails 6. But I have found no info on release dates. @arthurbdiniz Do you have any info on this?

@alaxalves alaxalves force-pushed the rails-6 branch from 433e66e to d98c346 Aug 21, 2019
@@ -39,7 +43,7 @@ group :dependencies do
gem 'rdiscount', '2.2.0.1'

# Process manager for applications with multiple components
gem 'foreman', '~> 0.85.0'
gem 'foreman', git: 'https://github.com/alaxalves/foreman.git', branch: 'master'

This comment has been minimized.

Copy link
@alaxalves

alaxalves Aug 21, 2019

Author Member

Had to do this to keep the thor gem compatibility both with rails and foreman gems. Done here

@arthurbdiniz

This comment has been minimized.

Copy link

arthurbdiniz commented Aug 21, 2019

@icarito @jywarren According to this link they have only mapped the upcoming functionalities for Rails 6. But I have found no info on release dates. @arthurbdiniz Do you have any info on this?

Hi everyone, I did some research here and I have some information for you guys.

The current rails version on Debian is 5.2.2. And all this information can be found on https://tracker.debian.org/pkg/rails

So I saw that rails 6.0.0 still not stable yet looking at https://github.com/rails/rails/releases
The latest stable is 5.2.3 and the Debian package maintainer is already in the process of upgrading, see https://salsa.debian.org/ruby-team/rails.

To the maintainer start the packaging of the rails 6.0.0 first this version needs to be on stable.

Since rails are within the Debian Ruby 鈥嬧婽eam and when rails come to a new stable release the maintainer is usually advised to make a new version of the package.

In case the maintainer disappears and show no sign of the new version, there are two ways to contact, by sending an email to the team list pkg-ruby-extras-maintainers@lists.alioth.debian.org or sending an email directly to the maintainer Utkarsh Gupta guptautkarsh2102@gmail.com, which is my friend 馃槃, showing interest in packaging the new version.

鈿狅笍 Remembering that we at Debian do as volunteer work and I recommend waiting a while before sending messages to the maintainer.

Extra

You can also find him on Debian IRC, the hostname is irc.debian.org which is an alias for irc.oftc.net on channel #debian-ruby or directly to him with the nickname utkarsh2102[m]

Hope this helps!

@alaxalves

This comment has been minimized.

Copy link
Member Author

alaxalves commented Aug 21, 2019

@icarito @jywarren According to this link they have only mapped the upcoming functionalities for Rails 6. But I have found no info on release dates. @arthurbdiniz Do you have any info on this?

Hi everyone, I did some research here and I have some information for you guys.

The current rails version on Debian is 5.2.2. And all this information can be found on https://tracker.debian.org/pkg/rails

So I saw that rails 6.0.0 still not stable yet looking at https://github.com/rails/rails/releases
The latest stable is 5.2.3 and the Debian package maintainer is already in the process of upgrading, see https://salsa.debian.org/ruby-team/rails.

To the maintainer start the packaging of the rails 6.0.0 first this version needs to be on stable.

Since rails are within the Debian Ruby 鈥嬧婽eam and when rails come to a new stable release the maintainer is usually advised to make a new version of the package.

In case the maintainer disappears and show no sign of the new version, there are two ways to contact, by sending an email to the team list pkg-ruby-extras-maintainers@lists.alioth.debian.org or sending an email directly to the maintainer Utkarsh Gupta guptautkarsh2102@gmail.com, which is my friend , showing interest in packaging the new version.

Remembering that we at Debian do as volunteer work and I recommend waiting a while before sending messages to the maintainer.

Extra

You can also find him on Debian IRC, the hostname is irc.debian.org which is an alias for irc.oftc.net on channel #debian-ruby or directly to him with the nickname utkarsh2102[m]

Hope this helps!

Thx a lot my dude! This was super helpful! Check this out @jywarren @icarito

@jywarren

This comment has been minimized.

Copy link
Contributor

jywarren commented Aug 21, 2019

Thank you so much, super helpful! Echoing something from @alaxalves from our chatroom:

Rails 6 has just been shipped
I think we'll soon have it packed on Debian
I'll update the merge
https://edgeguides.rubyonrails.org/6_0_release_notes.html
https://weblog.rubyonrails.org/2019/8/15/Rails-6-0-final-release/

馃槃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Rails Upgrade
Awaiting triage
5 participants
You can鈥檛 perform that action at this time.