Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Map loading #885

Merged
merged 14 commits into from Jul 30, 2019
Merged

Fixing Map loading #885

merged 14 commits into from Jul 30, 2019

Conversation

@alaxalves
Copy link
Member

alaxalves commented Jul 26, 2019

This PR is a little modified version of #882 to work with Rails 5.

h
h
fix
@alaxalves alaxalves force-pushed the testing-sasha-hotfix branch from a43a20d to 26716e6 Jul 26, 2019
…o testing-sasha-hotfix
@alaxalves alaxalves force-pushed the testing-sasha-hotfix branch 5 times, most recently from 82e49e0 to 3fdc472 Jul 26, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jul 26, 2019

Codecov Report

Merging #885 into development will decrease coverage by 24.16%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           development     #885       +/-   ##
================================================
- Coverage        72.67%   48.51%   -24.17%     
================================================
  Files               37       37               
  Lines             1343     1377       +34     
================================================
- Hits               976      668      -308     
- Misses             367      709      +342
Impacted Files Coverage Δ
lib/exporter.rb 0% <0%> (-92.04%) ⬇️
app/models/annotation.rb 53.33% <0%> (-46.67%) ⬇️
app/models/map.rb 53.06% <0%> (-40.14%) ⬇️
app/models/export.rb 69.44% <0%> (-30.56%) ⬇️
app/models/warpable.rb 63.21% <0%> (-24.14%) ⬇️
app/models/user.rb 92.85% <0%> (-7.15%) ⬇️
@alaxalves alaxalves mentioned this pull request Jul 26, 2019
0 of 5 tasks complete
@sashadev-sky

This comment has been minimized.

Copy link
Collaborator

sashadev-sky commented Jul 27, 2019

@sashadev-sky commenting myself here so i get updates on this

- npm i -g npm@6.9.0
- curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version 1.17.3
- export PATH="$HOME/.yarn/bin:$PATH"

This comment has been minimized.

Copy link
@kaustubh-nair

kaustubh-nair Jul 27, 2019

Collaborator

What is this supposed to be doing?

This comment has been minimized.

Copy link
@sashadev-sky

sashadev-sky Jul 27, 2019

Collaborator

I keep this as my yarn export path:

export PATH="$HOME/.yarn/bin:$HOME/.config/yarn/global/node_modules/.bin:$PATH"
@alaxalves alaxalves changed the title Fixing Map loading WIP: Fixing Map loading Jul 29, 2019
@alaxalves alaxalves force-pushed the testing-sasha-hotfix branch 8 times, most recently from 8a25a64 to 57fce65 Jul 29, 2019
@alaxalves alaxalves force-pushed the testing-sasha-hotfix branch from 57fce65 to ccafe26 Jul 29, 2019
@alaxalves alaxalves force-pushed the testing-sasha-hotfix branch 3 times, most recently from 225ae64 to a6869d8 Jul 29, 2019
@alaxalves alaxalves changed the title WIP: Fixing Map loading Fixing Map loading Jul 29, 2019
@alaxalves alaxalves force-pushed the development branch 2 times, most recently from 095a909 to 2d12491 Jul 29, 2019
@alaxalves alaxalves force-pushed the testing-sasha-hotfix branch from a6869d8 to bad9a98 Jul 30, 2019
…into testing-sasha-hotfix
@alaxalves alaxalves force-pushed the testing-sasha-hotfix branch from bad9a98 to 906beb3 Jul 30, 2019
@alaxalves

This comment has been minimized.

Copy link
Member Author

alaxalves commented Jul 30, 2019

image
Experiencing this super annoyin issue rn, but I think it's because of our dependencies folder definition in .yarnrc file. Yarn looks for the dependencies by default on node_modules/ folder and not the public/lib/ defined by us.

https://travis-ci.org/publiclab/mapknitter/builds/565274880?utm_source=github_status&utm_medium=notification

@alaxalves

This comment has been minimized.

Copy link
Member Author

alaxalves commented Jul 30, 2019

image
Experiencing this super annoyin issue rn, but I think it's because of our dependencies folder definition in .yarnrc file. Yarn looks for the dependencies by default on node_modules/ folder and not the public/lib/ defined by us.
https://travis-ci.org/publiclab/mapknitter/builds/565274880?utm_source=github_status&utm_medium=notification

Just confirmed this at: sass/node-sass#2050 (comment) and sass/node-sass#2050 (comment).

So basically, we should use node_modules/, since we don't need any other patterns, e.g. for production, I think it's a good idea to keep the NPM standard.

@alaxalves alaxalves force-pushed the testing-sasha-hotfix branch from 905207e to e09a75e Jul 30, 2019
@alaxalves alaxalves force-pushed the testing-sasha-hotfix branch from e09a75e to 2773d0e Jul 30, 2019
@alaxalves alaxalves merged commit 2773d0e into development Jul 30, 2019
2 of 4 checks passed
2 of 4 checks passed
codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
codecov/patch 93.18% of diff hit (target 72.51%)
Details
codecov/project 72.67% (+0.15%) compared to 3ca0b08
Details
@jywarren

This comment has been minimized.

Copy link
Contributor

jywarren commented Sep 9, 2019

Experiencing this super annoyin issue rn, but I think it's because of our dependencies folder definition in .yarnrc file. Yarn looks for the dependencies by default on node_modules/ folder and not the public/lib/ defined by us.

Hi folks, this change to .yarnrc may be causing us some trouble... the .yarnrc setting is needed to preserve public accessibility of yarn assets such as images, stylesheets, fonts.

I added it back in in main branch but we should try to work this problem. I'll copy this all to a new issue for discussion, thanks!

jywarren added a commit that referenced this pull request Sep 9, 2019
Re: #999 and #885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.