map editing permissions initial #937
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -257,6 +257,11 @@ def after_create | |||
| self.version = last.version + 1 | |||
| end | |||
|
|
|||
| def change_edit_permission editable | |||
There was a problem hiding this comment.
Use def with parentheses when there are parameters.
| @@ -257,6 +257,11 @@ def after_create | |||
| self.version = last.version + 1 | |||
| end | |||
|
|
|||
| def change_edit_permission editable | |||
| self.is_editable = editable | |||
| self.save! | |||
|
Code Climate has analyzed commit 78980d7 and detected 3 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
@jywarren I'm starting with this. We still need some more details on how to put the toggle permission button on the map sidebar. @sashadev-sky shared some cool ideas #893 . If you could have a look at this and the issue as well! |
Codecov Report
@@ Coverage Diff @@
## main #937 +/- ##
==========================================
- Coverage 72.71% 68.29% -4.42%
==========================================
Files 35 35
Lines 1356 1369 +13
==========================================
- Hits 986 935 -51
- Misses 370 434 +64
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #893