New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freezing with large #s of images or lower-power computers #24

Open
jywarren opened this Issue Dec 31, 2014 · 12 comments

Comments

Projects
None yet
3 participants
@jywarren
Contributor

jywarren commented Dec 31, 2014

thumbnail generation for lots of images may fail; create queue, indicate progress

This is very high priority -- getting queuing to work -- currently, more than a couple dozen images will overload the thumbnail generator and freeze up the browser. We just need to get the client side code to only attempt generating ~10 images at a time

@jywarren jywarren added the bug label Dec 31, 2014

@jywarren

This comment has been minimized.

Contributor

jywarren commented Mar 4, 2015

Addressed to some degree in #37, but I'm still seeing crashes on both Chrome and Chromium. What else can we do to reduce/ease off load on client?

@jywarren jywarren changed the title from thumbnail generation for lots of images may fail; create queue, indicate progress to freezing with large #s of images or lower-power computers Mar 4, 2015

@jywarren

This comment has been minimized.

Contributor

jywarren commented Mar 6, 2015

OK, this kind of works -- but still stalls. I wonder if we just tweak the # that are uploading at the same time down from 12. Try 3?

@jywarren

This comment has been minimized.

Contributor

jywarren commented Mar 6, 2015

Looks like we're missing code that was written directly into cartagen.js

@jywarren jywarren modified the milestone: 2.0.0 Mar 18, 2015

@numeroteca

This comment has been minimized.

numeroteca commented Nov 23, 2015

For me, with Firefox in ubuntu, the browser freezes when trying to upload around 20 images.
Maybe a banner saying that you have to upload them by chunks of 10 or 15 would help for the moment.

@jywarren

This comment has been minimized.

Contributor

jywarren commented Nov 30, 2015

I believe this was fixed in @rgovoni and @scoopergit's fork, but can't find where, and it's been mixed with a lot of application-specific code we don't necessarily want. Can either of you help us find and re-integrate your work on queueing and uploading large #s of images?

@jywarren

This comment has been minimized.

Contributor

jywarren commented Nov 30, 2015

@rgovoni

This comment has been minimized.

Contributor

rgovoni commented Dec 2, 2015

Hi Jeff, I fixed the limit on the uploading cue back in February (crowdgames@907e80e).
The lag time in uploading is still an issue depending on file size and connectivity. It's best if files are resized to 1440 px before upload.

@jywarren

This comment has been minimized.

Contributor

jywarren commented Dec 2, 2015

Thanks -- is that 1440 wide, maximum?

On Tue, Dec 1, 2015 at 7:02 PM, rgovoni notifications@github.com wrote:

Hi Jeff, I fixed the limit on the uploading cue back in February (
scoopergit@907e80e
crowdgames@907e80e).

The lag time in uploading is still an issue depending on file size and
connectivity. It's best if files are resized to 1440 px before upload.


Reply to this email directly or view it on GitHub
#24 (comment).

@rgovoni

This comment has been minimized.

Contributor

rgovoni commented Dec 2, 2015

Yes (at least that's where we're at, I'm sure other sizes would also work). Also -- line 61 of the sites.js file does allow you to change the simultaneous upload number, but I think 10 is pretty good (esp. for slow connections).

@jywarren

This comment has been minimized.

Contributor

jywarren commented Dec 4, 2015

Hmm, I believe we implemented the same fix:
4c59019

We should be able to queue them in the browser so that you don't have to
batch them. Pablo, how big are the photos you're uploading? What moment do
you think it gets stuck on? Generating the thumbnails? Or actually
uploading?

On Tue, Dec 1, 2015 at 7:07 PM, rgovoni notifications@github.com wrote:

Yes (at least that's where we're at, I'm sure other sizes would also
work). Also -- line 61 of the sites.js file does allow you to change the
simultaneous upload number, but I think 10 is pretty good (esp. for slow
connections).


Reply to this email directly or view it on GitHub
#24 (comment).

@numeroteca

This comment has been minimized.

numeroteca commented Dec 6, 2015

Photos are 2.3MB.
I think it crashes before generating the thumbnails.

@jywarren

This comment has been minimized.

Contributor

jywarren commented Jan 5, 2016

Hmm, i think we should try profiling it with the Web Developer tools and
see if we can track exactly when the slowdown happens in the code. Maybe
with breakpoints?

On Sun, Dec 6, 2015 at 5:46 AM, numeroteca notifications@github.com wrote:

Photos are 2.3MB.
I think it crashes before generating the thumbnails.


Reply to this email directly or view it on GitHub
#24 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment