Some kind of "unsubscribe" from Q&A threads

[jywarren]

We're starting to get threads that are long and active enough that people want to unsubscribe, like this one:

https://publiclab.org/questions/warren/09-08-2017/how-do-you-merge-gps-logger-data-into-photographs#answer-385-comment

This level of email notification is actually a fairly new feature and we haven't implemented an unsubscribe yet. GitHub has the "Not Watching/Watching/Ignoring" resolution but also the "following this thread" one... needs some thinking through.

The current system looks for /all/ thread participants, using this method for new comments:

https://github.com/publiclab/plots2/blob/master/app/models/comment.rb#L106

And this one for new answers:

https://github.com/publiclab/plots2/blob/master/app/models/answer.rb#L27

If we were to offer an unsubscribe, we might need to change this system to actually add people as "likers" or "followers" when they comment or answer, so we could delete their "following" status even though they participated in the thread, and we don't delete their comment or answer itself.

This could be complex and we may want to start by looking at how the "subscribe to thread" mechanism works, using node_selection rather than directly counting comments.

[jywarren]

@jlev thanks!

[jywarren]

@Gauravano is solving this in #3119, i believe!

[grvsachdeva]

You got it right @jywarren

[grvsachdeva]

Actually, #3119 is a small part of this unsubscribe system, we want to build. Currently, a user can unsubscribe from the the

1. Like notifications (user being author)
2. Comment notifications (user being author)
3. Indirect comment notification (user being commenter)

@jywarren we need to add more points to this, what do you think?

[jywarren]

hmm, answer notifications? what other kinds are there?

…

On Mon, Jul 23, 2018 at 1:10 PM Gaurav Sachdeva ***@***.***> wrote: Actually, #3119 <#3119> is a small part of this unsubscribe system, we want to build. Currently, a user can unsubscribe from the the 1. Like notifications (user being author) 2. Comment notifications (user being author) 3. Indirect comment notification (user being commenter) @jywarren <https://github.com/jywarren> we need to add more points to this, what do you think? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1610 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJwPV8jqi0dl3tdbA7Rg3RrHNcNYPks5uJgNegaJpZM4PT2Ro> .

[grvsachdeva]

yes answer notifications and unsubscribing from a node like @shapironick mentioned here #2910 (comment) . What do you think?

[jywarren]

agreed, so this is 2 additional types of unsubscribe?

Would Nick's suggestion be like, commented on a note but no longer want to be updated -- and how would we store that? Could we... store a "silence this thread" somewhere?

[grvsachdeva]

I think what we can do is: We can add button on each note labeled as "Silence this thread". That would block all notifications from that node- be it comments, like, etc. We need to put some more checks in this, but I guess its doable. And, we need to store this in a table may be NodeSelection otherwise usertags would fill up fastly. What do you think about this @jywarren ?

[jywarren]

nodeselection could work, would we set a true/false column added to nodeselection? and we can hide the button under the Like menu maybe? And add a link in comment emails themselves?

…

On Thu, Jul 26, 2018 at 5:25 PM Gaurav Sachdeva ***@***.***> wrote: I think what we can do is: We can add button on each note labeled as "Silence this thread". That would block all notifications from that node- be it comments, like, etc. We need to put some more checks in this, but I guess its doable. And, we need to store this in a table may be NodeSelection otherwise usertags would fill up fastly. What do you think about this @jywarren <https://github.com/jywarren> ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1610 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ8eGFJ6g0mHHQ4pqu54M2c7YH830ks5uKjOXgaJpZM4PT2Ro> .

[grvsachdeva]

The button can be added at many places, I guess we can come to that later. I will first see all places where NodeSelection is used, so that we don't mess up with any previous feature/function. Thanks!

[grvsachdeva]

Hi @jywarren I spent some time with NodeSelection, so here's the current situation. NodeSelection has these columns - uid, nid, following, liking. We use liking on our website actively. Coming to column following, I wasn't able to found any active functionality related to it, you have any idea?
Or, we can add new column like notification or subscription to the NodeSelection for storing the status. What do you think? Thanks!

[jywarren]

Hmm, I think we ended up using "liking" to mean both liking and following. Perhaps we should make pressing the button enable both a like and a follow, but then if you want you can "unselect" following so you don't take away the star but you don't get updates anymore?

…

On Mon, Jul 30, 2018 at 9:25 AM Gaurav Sachdeva ***@***.***> wrote: hi @jywarren <https://github.com/jywarren> I spent some time with NodeSelection, so here's the current situation. NodeSelection has these columns - uid, nid, following, liking. We use liking on our website actively. Coming to column following, I wasn't able to found any active functionality related to it, you have any idea? Or, we can add new column like notification or subscription to the NodeSelection for storing the status. What do you think? Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1610 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ8zmkJUUAbaa7acS-Q95QhayoS3Hks5uLwlDgaJpZM4PT2Ro> .

[grvsachdeva]

ok, so we are using following, for saving status. Ok, so I will raise a PR for migration as we need to change the following of all existing nodeselection rows to true and also we need to set default to true. What do you think @jywarren ? Thanks!

[grvsachdeva]

@jywarren so can I go for the above strategy?

[jywarren]

that sounds great!

…

On Tue, Jul 31, 2018 at 4:05 PM Gaurav Sachdeva ***@***.***> wrote: @jywarren <https://github.com/jywarren> so can I go for the above strategy? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1610 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ9XqiE4io4NrtD65IE2Pud2YERKuks5uMLhkgaJpZM4PT2Ro> .

[grvsachdeva]

Checklist for the Node Un-subscription:

• Make a migration for changing the default to true for new NodeSelection entries
• Migration for changing following column in NodeSelection to true for present rows in DB
• A controller method for handling subscribing and unsubscribing to node
• before sending email, a check which would ensure that email should not be sent to the user if he has un-subscribed to that node
• test for Emails

@jywarren I am following this checklist for this issue. Please add/change if I am forgetting something. Thanks!

[jywarren]

This looks good! Thanks!

…

On Thu, Aug 2, 2018, 7:32 AM Gaurav Sachdeva ***@***.***> wrote: Checklist for the Node Un-subscription: - Make a migration for changing the default to true for new NodeSelection entries - Migration for changing following column in NodeSelection to true for present rows in DB - A controller method for handling subscribing and unsubscribing to node - before sending email, a check which would ensure that email should not be sent to the user if he has un-subscribed to that node - test for Emails @jywarren <https://github.com/jywarren> I am following this checklist for this issue. Please add/change if I am forgetting something. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1610 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ3m99iQp9ue_MeTdnCrOGPD1fE1fks5uMuNDgaJpZM4PT2Ro> .