New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set node.icon based on tagging, rather than node.type, for display in search results #207
Comments
To clarify, this is in autocomplete results, right, not on http://publiclab.org/search ? |
it's on /search too. Shown here searching for "gulf coast", the Gulf Coast place page correctly has a flag icon. @steviepubliclab noticed that not all place pages have that, such as Chicago. This is something that lowers the functionality of our search. |
by /search i meant the full page results, like when you press enter for a I believe the other place these show up is in sidebar results. There may be On Tue, Feb 17, 2015 at 5:21 PM, Liz Barry notifications@github.com wrote:
|
Note: this should use Also a good chance to refactor |
@jywarren Please review the fix for this Issue. |
@jywarren One thing I couldn't figure out--How is the node type for certain places set to "place" for certain places? and how is the path set to |
"place" used to be a type of node, but we've deprecated those as much as possible in favor of simply using wiki pages. It'd be good to go through and thoroughly clean out that older system, and migrate any "place" nodes to "page" nodes.
Thanks for fixing this issue! |
@steviepubliclab noticed this because not all place pages have "flag" icons in search results. We think the various icons are helpful in search results for users just getting acquainted with the Public Lab community.
so perhaps, have the icons made “all same” or rejigger them to be based on tagging rather than intrinsic/Drupal node type.
The text was updated successfully, but these errors were encountered: