Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove link to /lists from sidebars #2117

Closed
SidharthBansal opened this issue Jan 25, 2018 · 9 comments · Fixed by #2121

Comments

@SidharthBansal
Copy link
Member

commented Jan 25, 2018

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!
🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

Please describe the problem

/lists from sidebars are no longer used
image

Solution

Remove link to /lists from sidebars
📋 Step by Step

🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  1. Remove plots2/app/views/sidebar/_list.html.erb
  2. Remove the line
    <%= render :partial => "sidebar/list" %>

💾 Commit your changes

🔀 Start a Pull Request.

🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!
Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

@williamlhelton

This comment has been minimized.

Copy link

commented Jan 25, 2018

Hello, I am a first timer. I'd like to try to fix this issue!

@ryzokuken

This comment has been minimized.

Copy link
Member

commented Jan 25, 2018

@williamlhelton Sure! Go ahead!

If you face any trouble, feel free to ask here or in our chatroom.

@williamlhelton

This comment has been minimized.

Copy link

commented Jan 25, 2018

EDIT: I forgot to remove the file plots2/app/views/sidebar/_list.html.erb. This pull request is no good.

Sorry, I'm nervous.

H̶i̶,̶ ̶I̶ ̶s̶t̶a̶r̶t̶e̶d̶ ̶a̶ ̶p̶u̶l̶l̶ ̶r̶e̶q̶u̶e̶s̶t̶.̶ ̶ ̶I̶ ̶d̶i̶d̶n̶'̶t̶ ̶k̶n̶o̶w̶ ̶h̶o̶w̶ ̶t̶o̶ ̶d̶o̶ ̶t̶h̶e̶ ̶c̶h̶e̶c̶k̶ ̶b̶o̶x̶e̶s̶ ̶o̶n̶ ̶t̶h̶e̶ ̶a̶u̶t̶o̶m̶a̶t̶e̶d̶ ̶m̶e̶s̶s̶a̶g̶e̶ ̶t̶h̶o̶u̶g̶h̶.̶ ̶ ̶A̶l̶s̶o̶ ̶f̶o̶r̶ ̶t̶h̶e̶ ̶c̶h̶a̶n̶g̶e̶ ̶i̶t̶s̶e̶l̶f̶,̶ ̶I̶ ̶d̶e̶l̶e̶t̶e̶d̶ ̶e̶x̶a̶c̶t̶l̶y̶ ̶t̶h̶e̶ ̶l̶i̶n̶e̶ ̶d̶e̶s̶c̶r̶i̶b̶e̶d̶ ̶i̶n̶ ̶t̶h̶e̶ ̶i̶s̶s̶u̶e̶,̶ ̶b̶u̶t̶ ̶i̶t̶ ̶w̶a̶s̶ ̶s̶u̶r̶r̶o̶u̶n̶d̶e̶d̶ ̶b̶y̶ ̶t̶w̶o̶ ̶<̶/̶ ̶b̶r̶>̶ ̶t̶a̶g̶s̶.̶ ̶ ̶S̶h̶o̶u̶l̶d̶ ̶I̶ ̶h̶a̶v̶e̶ ̶r̶e̶m̶o̶v̶e̶d̶ ̶o̶n̶e̶ ̶o̶f̶ ̶t̶h̶o̶s̶e̶ ̶a̶s̶ ̶w̶e̶l̶l̶?̶

@ryzokuken

This comment has been minimized.

Copy link
Member

commented Jan 25, 2018

@williamlhelton Don't be, it's okay to make mistakes. Also, you could just remove the file in a second commit and pushed that one alongside the first commit. There's no need to close the PR and make a new one.

@williamlhelton

This comment has been minimized.

Copy link

commented Jan 25, 2018

Hi. I think I'm ready to make a pull request again. I got a message saying:
Your pull request is on the master branch. Please make a separate feature branch

The instructions above only say 🔀 Start a Pull Request.

Should I make a separate feature branch for my Pull Request? If so, how do I do that?

@ryzokuken

This comment has been minimized.

Copy link
Member

commented Jan 25, 2018

Yes, it is advisable to create a separate branch for your changes to avoid the possibility of your master ever going out of sync with our master branch. If you are using the command like to manage git, just enter git checkout -b <branchname> to make a new branch. Otherwise, you will have to look up the documentation of the git client you are using.

@williamlhelton

This comment has been minimized.

Copy link

commented Jan 25, 2018

Hi, I am very confused.

So I am ready to make a Pull Request with my changes. My changes are in a fork (williamlhelton/plots2).

I can not create a branch on publiclab. I can create branches on my own fork but I don't see what the difference is between my changes being in "master" or something else. I think I should be merging into a branch on publiclab/plots2 but I can't make a new one.

I can change the "master" on publiclab to a different branch like "fixes" or "first-timers-made-this" but then all of the changes other people have made show up and I don't want that. I'm not sure what my next step should be.

@jywarren jywarren removed the fto-candidate label Jan 25, 2018

@ryzokuken

This comment has been minimized.

Copy link
Member

commented Jan 25, 2018

@williamlhelton you should make your changes in a branch (other than master, of course) in your own repo, and make a PR from that branch to our master.

but I don't see what the difference is between my changes being in "master" or something else

The difference is that if the changes are merged in an uneven manner (a lot of people make PRs for the master branch each day, so it is unlikely that yours will get merged the first, right?), your master branch will go out of sync with our master branch, which isn't something you'd like (and by extension, we wouldn't like it either).

However, if you make a temporary branch for the changes and get those merged to our master, you can easily just dump that branch, update your master to reflect our master and move ahead (the cycle continues).

This is generally the pattern followed by open-source projects (especially larger ones) mainly because it saves you from a lot of trouble later, plus it keeps things organized.

@williamlhelton

This comment has been minimized.

Copy link

commented Jan 25, 2018

Hi. Okay, that makes sense. I was confused about how branches worked.

I think I did it right this time. I made a Pull Request from a branch in my repo to your master.

jywarren added a commit that referenced this issue Jan 25, 2018
Remove link to /lists from sidebars #2117
/lists from sidebars are no longer used
Remove plots2/app/views/sidebar/_list.html.erb
Remove a line from _related.html.erb
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this issue May 5, 2019
Remove link to /lists from sidebars publiclab#2117
/lists from sidebars are no longer used
Remove plots2/app/views/sidebar/_list.html.erb
Remove a line from _related.html.erb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.