Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove link to /lists from sidebars #2117
Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.
If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!
We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you
If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!
Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.
Please describe the problem
Remove link to /lists from sidebars
Leave a comment below!
We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!
Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.
EDIT: I forgot to remove the file plots2/app/views/sidebar/_list.html.erb. This pull request is no good.
Sorry, I'm nervous.
H̶i̶,̶ ̶I̶ ̶s̶t̶a̶r̶t̶e̶d̶ ̶a̶ ̶p̶u̶l̶l̶ ̶r̶e̶q̶u̶e̶s̶t̶.̶ ̶ ̶I̶ ̶d̶i̶d̶n̶'̶t̶ ̶k̶n̶o̶w̶ ̶h̶o̶w̶ ̶t̶o̶ ̶d̶o̶ ̶t̶h̶e̶ ̶c̶h̶e̶c̶k̶ ̶b̶o̶x̶e̶s̶ ̶o̶n̶ ̶t̶h̶e̶ ̶a̶u̶t̶o̶m̶a̶t̶e̶d̶ ̶m̶e̶s̶s̶a̶g̶e̶ ̶t̶h̶o̶u̶g̶h̶.̶ ̶ ̶A̶l̶s̶o̶ ̶f̶o̶r̶ ̶t̶h̶e̶ ̶c̶h̶a̶n̶g̶e̶ ̶i̶t̶s̶e̶l̶f̶,̶ ̶I̶ ̶d̶e̶l̶e̶t̶e̶d̶ ̶e̶x̶a̶c̶t̶l̶y̶ ̶t̶h̶e̶ ̶l̶i̶n̶e̶ ̶d̶e̶s̶c̶r̶i̶b̶e̶d̶ ̶i̶n̶ ̶t̶h̶e̶ ̶i̶s̶s̶u̶e̶,̶ ̶b̶u̶t̶ ̶i̶t̶ ̶w̶a̶s̶ ̶s̶u̶r̶r̶o̶u̶n̶d̶e̶d̶ ̶b̶y̶ ̶t̶w̶o̶ ̶<̶/̶ ̶b̶r̶>̶ ̶t̶a̶g̶s̶.̶ ̶ ̶S̶h̶o̶u̶l̶d̶ ̶I̶ ̶h̶a̶v̶e̶ ̶r̶e̶m̶o̶v̶e̶d̶ ̶o̶n̶e̶ ̶o̶f̶ ̶t̶h̶o̶s̶e̶ ̶a̶s̶ ̶w̶e̶l̶l̶?̶
Hi. I think I'm ready to make a pull request again. I got a message saying:
The instructions above only say
Should I make a separate feature branch for my Pull Request? If so, how do I do that?
Yes, it is advisable to create a separate branch for your changes to avoid the possibility of your master ever going out of sync with our master branch. If you are using the command like to manage git, just enter
Hi, I am very confused.
So I am ready to make a Pull Request with my changes. My changes are in a fork (williamlhelton/plots2).
I can not create a branch on publiclab. I can create branches on my own fork but I don't see what the difference is between my changes being in "master" or something else. I think I should be merging into a branch on publiclab/plots2 but I can't make a new one.
I can change the "master" on publiclab to a different branch like "fixes" or "first-timers-made-this" but then all of the changes other people have made show up and I don't want that. I'm not sure what my next step should be.
@williamlhelton you should make your changes in a branch (other than master, of course) in your own repo, and make a PR from that branch to our master.
The difference is that if the changes are merged in an uneven manner (a lot of people make PRs for the master branch each day, so it is unlikely that yours will get merged the first, right?), your master branch will go out of sync with our master branch, which isn't something you'd like (and by extension, we wouldn't like it either).
However, if you make a temporary branch for the changes and get those merged to our master, you can easily just dump that branch, update your master to reflect our master and move ahead (the cycle continues).
This is generally the pattern followed by open-source projects (especially larger ones) mainly because it saves you from a lot of trouble later, plus it keeps things organized.