Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Answer update not working(routes issue) #3063

Closed
first-timers bot opened this issue Jul 13, 2018 · 9 comments

Comments

Projects
None yet
4 participants
@first-timers
Copy link

commented Jul 13, 2018

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file config/routes.rb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -287,6 +287,7 @@
   post 'answers/create/:nid' => 'answers#create'
   get 'answers/create/:nid' => 'answers#create'
   get 'answers/update/:id' => 'answers#update'
+  post 'answers/update/:id' => 'answers#update'
   put 'answers/update/:id' => 'answers#update'
   get 'answers/delete/:id' => 'answers#delete'
   delete 'answers/delete/:id' => 'answers#delete'
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@CoderJolly

This comment has been minimized.

Copy link
Member

commented Jul 13, 2018

pls assign issue

@ViditChitkara

This comment has been minimized.

Copy link
Member

commented Jul 14, 2018

Please go ahead! Thanks.

@Souravirus

This comment has been minimized.

Copy link
Member

commented Jul 14, 2018

Hi @CoderJolly, you can work on this. just mention this issue on the PR, so that we can get track of it. Thanks!!

@srbcheema1

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2018

@ViditChitkara @Souravirus @CoderJolly May I fix this issue?

@CoderJolly

This comment has been minimized.

Copy link
Member

commented Jul 16, 2018

actually, I was busy bt i m working on it

@Souravirus

This comment has been minimized.

Copy link
Member

commented Jul 16, 2018

ok @CoderJolly, if you want to work then submit a PR. @srbcheema1 might write tests for this change if he wants. I will prepare a first-timers issue for this. Thanks!!

@CoderJolly

This comment has been minimized.

Copy link
Member

commented Jul 16, 2018

ok submitting now @Souravirus

@CoderJolly CoderJolly referenced this issue Jul 16, 2018

Merged

Updated routes.rb #3075

5 of 5 tasks complete
@srbcheema1

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2018

yeah sure @Souravirus :)

@Souravirus

This comment has been minimized.

Copy link
Member

commented Jul 18, 2018

Closing this. Thanks @CoderJolly

@Souravirus Souravirus closed this Jul 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.