Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Notification System for PL #3283

Closed
SidharthBansal opened this issue Sep 1, 2018 · 12 comments
Closed

Design Notification System for PL #3283

SidharthBansal opened this issue Sep 1, 2018 · 12 comments
Labels
help wanted requires help by anyone willing to contribute more-detail-please issue lacks proper description and perhaps needs code links or the location of the problem outreach issues involve community involvement and helping people who're stuck somewhere

Comments

@SidharthBansal
Copy link
Member

Please describe the problem (or idea)

We can have a notification system at Public Labs in the header. We currently don't have such notification system. We usually notify people via email. We can notify them like facebook, linkedin etc does.
image

@SidharthBansal SidharthBansal added the more-detail-please issue lacks proper description and perhaps needs code links or the location of the problem label Sep 1, 2018
@SidharthBansal
Copy link
Member Author

@publiclab/reviewers @publiclab/soc any ideas about this is much appreciated.

@siaw23-retired
Copy link
Collaborator

would be a pretty cool feature. i'm for it. this will be done with action cable i believe?

@SidharthBansal
Copy link
Member Author

SidharthBansal commented Sep 1, 2018 via email

@SidharthBansal
Copy link
Member Author

We will definitely create a large list of issue, but if we will break one or two bigger projects to them it will also help the pl community. What do you say @siaw23 @jywarren. Yeah @siaw23 you can go for it. Let's also hear from other community members what they are looking for.

Btw this will be a big project. We also need to have a web page for showing all the notifications.

@SidharthBansal SidharthBansal added the outreach issues involve community involvement and helping people who're stuck somewhere label Sep 1, 2018
@siaw23-retired
Copy link
Collaborator

uuum won't this be too big for GCI students? well sure i can help with overseeing this if we can have a clear plan what to set notifications for.

@SidharthBansal
Copy link
Member Author

SidharthBansal commented Sep 1, 2018 via email

@jywarren
Copy link
Member

jywarren commented Sep 5, 2018

Wow, very cool! Actually i wonder if it could be implemented via the Notifications API - that way it can work on phones too:

#2497

Or is this what action cable does? I'm not familiar with it!

@SidharthBansal
Copy link
Member Author

Helpful links
https://gorails.com/episodes/in-app-navbar-notifications
https://www.youtube.com/watch?v=87fBAWc25Sk
I am trying to learn this stuff first. @siaw23 if you know the notification stuff we can move according to your strategy.
Thanks all

@siaw23-retired
Copy link
Collaborator

I think the first link is using AJAX. There's a better way. We should use web sockets with Action Cable instead, comes with Rails 5. The second link is something completely different, just plain flash messages. That's not what we want. Are you going to build this or a GCI student again? One important thing worth defining is for WHICH events do we want the notifications? I think that needs to be spelled out, do we want notifications for mentions? new posts? new replies? Then based on that we can design this from scratch.

@SidharthBansal
Copy link
Member Author

SidharthBansal commented Sep 17, 2018 via email

@jywarren
Copy link
Member

jywarren commented Sep 17, 2018 via email

@jywarren jywarren added the help wanted requires help by anyone willing to contribute label Dec 3, 2018
@jywarren
Copy link
Member

jywarren commented Feb 5, 2019

I'm going to merge this into #2497! Thanks!

@jywarren jywarren closed this as completed Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted requires help by anyone willing to contribute more-detail-please issue lacks proper description and perhaps needs code links or the location of the problem outreach issues involve community involvement and helping people who're stuck somewhere
Projects
None yet
Development

No branches or pull requests

3 participants