New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add range buttons to /tag/____ page #3298

Open
first-timers bot opened this Issue Sep 5, 2018 · 6 comments

Comments

Projects
None yet
5 participants
@first-timers

first-timers bot commented Sep 5, 2018

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

We have a nice way of displaying activity on a topic for just a given time period: https://publiclab.org/tag/data-logging?start=16-03-2016&end=14-04-2017 (from #2439) --

...but no easy way to get to such a range-limited page from the basic page of https://publiclab.org/tag/data-logging. So this adds some nice buttons!

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file app/views/tag/show.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -51,7 +51,11 @@
   <% end %>
 
   <h3><% unless @tags.try(:first).try(:parent).nil? %><small>parent: <%= @tags.first.parent %></small><% end %></h3>
-  <%= render :partial => "notes/format_toggle" if @node_type == "note" %>
+  
+  <div class="btn-group visible-desktop" style="float:right;" id="note-format">
+    <a class="btn btn-default btn-sm" href="?start=<%= (@start || Time.now - 1.month).to_formatted_s(:long) %>&end=<%= (@end || Time.now).to_formatted_s(:long) %>">month</a>
+    <a class="btn btn-default btn-sm" href="?start=<%= (@start || Time.now - 1.year).to_formatted_s(:long) %>&end=<%= (@end || Time.now).to_formatted_s(:long) %>">year</a>
+  </div>
 
   <% if current_user %>
   <!-- AJAXify -->
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@yangmichaelkcs

This comment has been minimized.

Show comment
Hide comment
@yangmichaelkcs

yangmichaelkcs Sep 6, 2018

Can I try this?

yangmichaelkcs commented Sep 6, 2018

Can I try this?

@AmanGarg97

This comment has been minimized.

Show comment
Hide comment
@AmanGarg97

AmanGarg97 Sep 6, 2018

Hey! I made a PR for this issue ( PR #3300 ).Please review this. Thanks!

AmanGarg97 commented Sep 6, 2018

Hey! I made a PR for this issue ( PR #3300 ).Please review this. Thanks!

@yash98gupta

This comment has been minimized.

Show comment
Hide comment
@yash98gupta

yash98gupta Sep 8, 2018

can i try ? i am new to open source

yash98gupta commented Sep 8, 2018

can i try ? i am new to open source

@jywarren

This comment has been minimized.

Show comment
Hide comment
@jywarren

jywarren Sep 8, 2018

Contributor
Contributor

jywarren commented Sep 8, 2018

@SidharthBansal SidharthBansal referenced this issue Sep 12, 2018

Closed

Update show.html.erb `fixes #3298` #3300

5 of 5 tasks complete

@AmanGarg97 AmanGarg97 referenced this issue Sep 19, 2018

Open

added buttons `fixes #3298` #3347

5 of 5 tasks complete
@Paarmita

This comment has been minimized.

Show comment
Hide comment
@Paarmita

Paarmita Sep 23, 2018

Contributor

@jywarren Is this issue still open to work on?

Contributor

Paarmita commented Sep 23, 2018

@jywarren Is this issue still open to work on?

@jywarren

This comment has been minimized.

Show comment
Hide comment
@jywarren

jywarren Sep 23, 2018

Contributor

Hi, it looks like @AmanGarg97 is working on it in #3347 - but having some trouble. If you could test their code and upload a screenshot that'd be very helpful - and if you can help them figure out their install issues we'd also be grateful!

Contributor

jywarren commented Sep 23, 2018

Hi, it looks like @AmanGarg97 is working on it in #3347 - but having some trouble. If you could test their code and upload a screenshot that'd be very helpful - and if you can help them figure out their install issues we'd also be grateful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment