New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment templates to comment form #3317

Open
first-timers bot opened this Issue Sep 13, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@first-timers

first-timers bot commented Sep 13, 2018

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file app/views/comments/_form.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -12,7 +12,15 @@
   <% end %>
 
   <div class="form-group dropzone">
-    <textarea style="border: 1px solid #bbb;border-bottom-left-radius: 0;border-bottom-right-radius: 0;border-bottom: 0;padding: 10px;" onFocus="editing=true" name="body" class="form-control" id="text-input" rows="6" cols="40" placeholder="<%= placeholder %>"><%= params[:body] %></textarea>
+
+    <% 
+      body = params[:body]
+      # Look for comment templates
+      if params[:body].empty? && @node && @node.has_power_tag('comment-template')
+        body = Node.find(@node.power_tag('comment-template').to_i).body
+      end
+    %>
+    <textarea style="border: 1px solid #bbb;border-bottom-left-radius: 0;border-bottom-right-radius: 0;border-bottom: 0;padding: 10px;" onFocus="editing=true" name="body" class="form-control" id="text-input" rows="6" cols="40" placeholder="<%= placeholder %>"><%= body %></textarea>
 
     <div id="imagebar">
 
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@debrachoo

This comment has been minimized.

Show comment
Hide comment
@debrachoo

debrachoo Sep 14, 2018

Can I try this?

debrachoo commented Sep 14, 2018

Can I try this?

@SidharthBansal

This comment has been minimized.

Show comment
Hide comment
@SidharthBansal

SidharthBansal Sep 14, 2018

Member

Yes go ahead.

Member

SidharthBansal commented Sep 14, 2018

Yes go ahead.

@jywarren

This comment has been minimized.

Show comment
Hide comment
@jywarren

jywarren Sep 14, 2018

Contributor

Actually @debrachoo -- i had another idea -- to try to change this line:

body = Node.find(@node.power_tag('comment-template').to_i).body

To:

body = Node.find_by(slug: @node.power_tag('comment-template')).try(:body)

This should both make it possible to specify a template by the page URL instead of its id, AND have it default to 'nil' if nothing's found. Make sense? Thanks for your help!

Contributor

jywarren commented Sep 14, 2018

Actually @debrachoo -- i had another idea -- to try to change this line:

body = Node.find(@node.power_tag('comment-template').to_i).body

To:

body = Node.find_by(slug: @node.power_tag('comment-template')).try(:body)

This should both make it possible to specify a template by the page URL instead of its id, AND have it default to 'nil' if nothing's found. Make sense? Thanks for your help!

@debrachoo

This comment has been minimized.

Show comment
Hide comment
@debrachoo

debrachoo Sep 18, 2018

eh I'm lost. I changed something, did a pull request. And there are some checks that are running?

debrachoo commented Sep 18, 2018

eh I'm lost. I changed something, did a pull request. And there are some checks that are running?

@SidharthBansal

This comment has been minimized.

Show comment
Hide comment
@SidharthBansal

SidharthBansal Sep 18, 2018

Member

These are Travis tests. They are used at many open source repositories to ensure that your code does not effect the other functions present.
No need to worry. Wait for some time till the time they will be completed.

Member

SidharthBansal commented Sep 18, 2018

These are Travis tests. They are used at many open source repositories to ensure that your code does not effect the other functions present.
No need to worry. Wait for some time till the time they will be completed.

@jywarren jywarren referenced this issue Sep 18, 2018

Open

Updated _form.html.erb #3344

0 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment