New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label for "replied by email" icon #3321

Closed
first-timers bot opened this Issue Sep 14, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@first-timers

first-timers bot commented Sep 14, 2018

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

This change turns the icon into just an icon (not a button) and adds a tooltip indicating what it means -- that the comment was sent by email! Very helpful! 👍

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file app/views/notes/_comment.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -40,7 +40,7 @@
         </a>
       <% end %>
       <% if comment.comment_via == 1 %>
-        <a href="#" onclick="return false;" class="btn btn-default btn-sm"><i class="fa fa-envelope"></i></a>
+        <i class="fa fa-envelope" rel="tooltip" title="Commented by email"></i> &nbsp;
       <% end %>
       <% if params[:controller] == "questions" && current_user && (current_user.role == "admin" || current_user.role == "moderator" || comment.uid == current_user.uid) %>
         <a class="btn btn-default btn-sm" id="comment-<%= comment.id %>-reorder-btn" data-remote="true" data-confirm="Are you sure? <% if current_user && comment.uid != current_user.uid %>Please exercise caution in promoting others' comments; this cannot be undone.<% end %>" rel="tooltip" title="<%= t('questions._comment.promotion') %>" data-placement="left" href="/comment/make_answer/<%= comment.id %>"><i class="fa fa-plus"></i></a>
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@jywarren jywarren changed the title from Update _comment.html.erb to Add label for "replied by email" icon Sep 14, 2018

@DanilParshukov

This comment has been minimized.

Show comment
Hide comment
@DanilParshukov

DanilParshukov Sep 14, 2018

Contributor

Hello, could I take this issue?

Contributor

DanilParshukov commented Sep 14, 2018

Hello, could I take this issue?

@gauravano

This comment has been minimized.

Show comment
Hide comment
@gauravano

gauravano Sep 14, 2018

Member

Hi @DanilParshukov that would be great. Thanks!

Member

gauravano commented Sep 14, 2018

Hi @DanilParshukov that would be great. Thanks!

@DanilParshukov

This comment has been minimized.

Show comment
Hide comment
@DanilParshukov

DanilParshukov Sep 15, 2018

Contributor

Please review #3334

Contributor

DanilParshukov commented Sep 15, 2018

Please review #3334

@jywarren

This comment has been minimized.

Show comment
Hide comment
@jywarren

jywarren Sep 18, 2018

Contributor

Thanks! This was solved by @DanilParshukov -- fantastic work! 👍 👍 👍

Contributor

jywarren commented Sep 18, 2018

Thanks! This was solved by @DanilParshukov -- fantastic work! 👍 👍 👍

@jywarren jywarren closed this Sep 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment