New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "welcome" feature to the sidebar for non-logged-in people #3341

Closed
first-timers bot opened this Issue Sep 17, 2018 · 16 comments

Comments

Projects
None yet
5 participants
@first-timers

first-timers bot commented Sep 17, 2018

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file app/views/sidebar/_related.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -64,5 +64,11 @@
     </div>
   <% end %>
   
+  <% unless current_user %>
+    <% cache('related_sidebar-welcome', skip_digest: true) do %>
+      <%= feature('sidebar-welcome') %>
+    <% end %>
+  <% end %>
+
 </div>
 <%= javascript_include_tag 'sidebar' %>
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@jywarren

This comment has been minimized.

Show comment
Hide comment
@jywarren

jywarren Sep 17, 2018

Contributor

We store the text content in the database, so all we need to insert here is the feature code snippet itself!

Contributor

jywarren commented Sep 17, 2018

We store the text content in the database, so all we need to insert here is the feature code snippet itself!

@jywarren

This comment has been minimized.

Show comment
Hide comment
@jywarren

jywarren Sep 17, 2018

Contributor

This one is for @maciejmyslinski !

Contributor

jywarren commented Sep 17, 2018

This one is for @maciejmyslinski !

@mishaelajay

This comment has been minimized.

Show comment
Hide comment
@mishaelajay

mishaelajay Sep 19, 2018

Hi can i work on this if its not already being worked on that is. :)

mishaelajay commented Sep 19, 2018

Hi can i work on this if its not already being worked on that is. :)

@aSquare14

This comment has been minimized.

Show comment
Hide comment
@aSquare14

aSquare14 Sep 20, 2018

Member

I'd like to claim this issue !

Member

aSquare14 commented Sep 20, 2018

I'd like to claim this issue !

@aSquare14 aSquare14 referenced this issue Sep 20, 2018

Closed

Adds a "welcome" feature to the sidebar #3364

5 of 5 tasks complete
@SidharthBansal

This comment has been minimized.

Show comment
Hide comment
@SidharthBansal

SidharthBansal Sep 20, 2018

Member

@AMI1995 go ahead. @aSquare14 you can try other ftos.

Member

SidharthBansal commented Sep 20, 2018

@AMI1995 go ahead. @aSquare14 you can try other ftos.

@SidharthBansal

This comment has been minimized.

Show comment
Hide comment
@SidharthBansal

SidharthBansal Sep 20, 2018

Member

@aSquare14 we need to give priority to the person who asks for the issue first. Sorry.

Member

SidharthBansal commented Sep 20, 2018

@aSquare14 we need to give priority to the person who asks for the issue first. Sorry.

@SidharthBansal

This comment has been minimized.

Show comment
Hide comment
@SidharthBansal

SidharthBansal Sep 20, 2018

Member

@AMI1995 if get stuck feel free to ask for help.

Member

SidharthBansal commented Sep 20, 2018

@AMI1995 if get stuck feel free to ask for help.

@aSquare14

This comment has been minimized.

Show comment
Hide comment
@aSquare14

aSquare14 Sep 20, 2018

Member

@AMI1995 Sorry for the confusion. All the best working on it 😄 I'll work on a different issue #3363 assigned to me by @SidharthBansal :)

Member

aSquare14 commented Sep 20, 2018

@AMI1995 Sorry for the confusion. All the best working on it 😄 I'll work on a different issue #3363 assigned to me by @SidharthBansal :)

@Paarmita

This comment has been minimized.

Show comment
Hide comment
@Paarmita

Paarmita Sep 23, 2018

Member

@SidharthBansal Can I take up this?

Member

Paarmita commented Sep 23, 2018

@SidharthBansal Can I take up this?

@SidharthBansal

This comment has been minimized.

Show comment
Hide comment
@SidharthBansal

SidharthBansal Sep 24, 2018

Member

No someone is working on it.
Please try other issues
Thanks

Member

SidharthBansal commented Sep 24, 2018

No someone is working on it.
Please try other issues
Thanks

@jywarren

This comment has been minimized.

Show comment
Hide comment
@jywarren

jywarren Sep 24, 2018

Contributor

Hi, @Paarmita -- thanks for your interest! I think it's possible @AMI1995 is stuck on this, or may also just be busy with other things, and I think that if you wanted to give it a try, we can help @AMI1995 find a new issue to work on. I haven't seen a pull request from them yet, in any case. Please be sure to open one promptly so we know you're actively working on this.

Thanks! 👍

Contributor

jywarren commented Sep 24, 2018

Hi, @Paarmita -- thanks for your interest! I think it's possible @AMI1995 is stuck on this, or may also just be busy with other things, and I think that if you wanted to give it a try, we can help @AMI1995 find a new issue to work on. I haven't seen a pull request from them yet, in any case. Please be sure to open one promptly so we know you're actively working on this.

Thanks! 👍

@Paarmita

This comment has been minimized.

Show comment
Hide comment
@Paarmita

Paarmita Sep 25, 2018

Member

@jywarren Thanks! I'm stuck in installing the project locally, after resolving it I can start working on it.

Member

Paarmita commented Sep 25, 2018

@jywarren Thanks! I'm stuck in installing the project locally, after resolving it I can start working on it.

@jywarren

This comment has been minimized.

Show comment
Hide comment
@jywarren

jywarren Sep 25, 2018

Contributor
Contributor

jywarren commented Sep 25, 2018

@Paarmita

This comment has been minimized.

Show comment
Hide comment
@Paarmita

Paarmita Sep 25, 2018

Member

@SidharthBansal @jywarren I added the code in app/views/sidebar/_related.html.erb but where can I see the feature I added?

Member

Paarmita commented Sep 25, 2018

@SidharthBansal @jywarren I added the code in app/views/sidebar/_related.html.erb but where can I see the feature I added?

@jywarren

This comment has been minimized.

Show comment
Hide comment
@jywarren

jywarren Sep 25, 2018

Contributor
Contributor

jywarren commented Sep 25, 2018

@mishaelajay

This comment has been minimized.

Show comment
Hide comment
@mishaelajay

mishaelajay Sep 26, 2018

@SidharthBansal @jywarren My apologies. My laptop had a few issues and was unable to do any work the past couple of days. Please let me know if i can take up another issue. So sorry for the delay in my response.

mishaelajay commented Sep 26, 2018

@SidharthBansal @jywarren My apologies. My laptop had a few issues and was unable to do any work the past couple of days. Please let me know if i can take up another issue. So sorry for the delay in my response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment