New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display message in collections in Public Lab Store #3359

Open
aSquare14 opened this Issue Sep 20, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@aSquare14
Member

aSquare14 commented Sep 20, 2018

We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.

Please describe the problem (or idea)

In the collections, collections that do not have any product (eg. photography) should have a message displayed below the heading "Sorry, there are no products in this collection"

Currently, it displays "See more Photography "

Please show us where to look

https://store.publiclab.org/collections
Photography section

What's your PublicLab.org username?

asquare14

This can help us diagnose the issue:

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!


We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.

@SidharthBansal

This comment has been minimized.

Show comment
Hide comment
@SidharthBansal

SidharthBansal Sep 20, 2018

Member

@aSquare14 I am having difficulty in reproducing the error.
I tried following and got this
image
can you please help in explaining about the error?

Member

SidharthBansal commented Sep 20, 2018

@aSquare14 I am having difficulty in reproducing the error.
I tried following and got this
image
can you please help in explaining about the error?

@aSquare14

This comment has been minimized.

Show comment
Hide comment
@aSquare14

aSquare14 Sep 20, 2018

Member

It is not related to search. Just a UI enhancement.

  1. Go to Photography section in collections.
  2. You will notice it has no products listed.
  3. Instead of displaying a hyperlink saying "See more Photography", we should display "Sorry, there are no products in this collection."

In the picture below, we need to update the message.
screenshot from 2018-09-20 10-45-13

Member

aSquare14 commented Sep 20, 2018

It is not related to search. Just a UI enhancement.

  1. Go to Photography section in collections.
  2. You will notice it has no products listed.
  3. Instead of displaying a hyperlink saying "See more Photography", we should display "Sorry, there are no products in this collection."

In the picture below, we need to update the message.
screenshot from 2018-09-20 10-45-13

@SidharthBansal

This comment has been minimized.

Show comment
Hide comment
@SidharthBansal

SidharthBansal Sep 20, 2018

Member

Yeah nice catch.
Can you please send patch to this bug?
Thanks

Member

SidharthBansal commented Sep 20, 2018

Yeah nice catch.
Can you please send patch to this bug?
Thanks

@aSquare14

This comment has been minimized.

Show comment
Hide comment
@aSquare14

aSquare14 Sep 20, 2018

Member

I think it would be better suited for GCI candidate 👍 Thanks.

Member

aSquare14 commented Sep 20, 2018

I think it would be better suited for GCI candidate 👍 Thanks.

@SidharthBansal

This comment has been minimized.

Show comment
Hide comment
@SidharthBansal

SidharthBansal Sep 20, 2018

Member

Can you please make issue like #3342? and close this one. Also link this conversation there.
We need to be much more friendly to the newcomers. Follow a similar template. Provide the necessary code links.
Also, I want to tell that we have 2 kind of gci-candidate issues

  1. Issues labelled with gci-candidate these are little advanced to be solved
  2. Issues labelled with gci-candidate and first-timers-only -->these are for first timer gci candidates. They have detailed steps and hints. May be we can provide them whole solution.

There is one more category first timers only these issues are first timers and can be handled by any one except gci candidates. (for elderly fellows). They also have detailed hints and steps.

I think this could be labelled with first-timers and gci-candidate.

Member

SidharthBansal commented Sep 20, 2018

Can you please make issue like #3342? and close this one. Also link this conversation there.
We need to be much more friendly to the newcomers. Follow a similar template. Provide the necessary code links.
Also, I want to tell that we have 2 kind of gci-candidate issues

  1. Issues labelled with gci-candidate these are little advanced to be solved
  2. Issues labelled with gci-candidate and first-timers-only -->these are for first timer gci candidates. They have detailed steps and hints. May be we can provide them whole solution.

There is one more category first timers only these issues are first timers and can be handled by any one except gci candidates. (for elderly fellows). They also have detailed hints and steps.

I think this could be labelled with first-timers and gci-candidate.

@aSquare14

This comment has been minimized.

Show comment
Hide comment
@aSquare14

aSquare14 Sep 20, 2018

Member

Okay. Will do !

Member

aSquare14 commented Sep 20, 2018

Okay. Will do !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment