New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination Component needs to be removed from home page if user is not logged in. #3360

Open
aSquare14 opened this Issue Sep 20, 2018 · 7 comments

Comments

Projects
None yet
3 participants
@aSquare14
Member

aSquare14 commented Sep 20, 2018

Please describe the problem (or idea)

In references to issues #3301, #2173.

  • Pagination is NOT broken in the home page. It redirects to the home page (correct behaviour) if a user is not logged in. This is because to view the other pages, you need to be logged in.
  • It works perfectly if the user is logged in. Because after logging in,URL changes to /dashboard.
  • We should just remove the pagination component from home page if the user is not logged in.

Please show us where to look

https://publiclab.org/?page=3

What's your PublicLab.org username?

asquare14

This can help us diagnose the issue:

Browser, version, and operating system

Chrome. Ubuntu 16.04

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!


We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.

Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@SidharthBansal

This comment has been minimized.

Show comment
Hide comment
@SidharthBansal

SidharthBansal Sep 20, 2018

Member

Can you please turn this to a first timer issue? I will remove my comment. Add please add a line that will say that this issue is for only first timers students of google code in.
Thanks for reporting so many bugs here at pl(ie public labs)

Member

SidharthBansal commented Sep 20, 2018

Can you please turn this to a first timer issue? I will remove my comment. Add please add a line that will say that this issue is for only first timers students of google code in.
Thanks for reporting so many bugs here at pl(ie public labs)

@jywarren

This comment has been minimized.

Show comment
Hide comment
@jywarren

jywarren Sep 20, 2018

Contributor

Hi! A few extra bits of into and formatting would be very helpful to make this a proper first timers only issue. Would you mind using this as a model?

#3363

There's more guidance on writing first timers only issues at code.publiclab.org as well.

Thank you so much!!!!!

Contributor

jywarren commented Sep 20, 2018

Hi! A few extra bits of into and formatting would be very helpful to make this a proper first timers only issue. Would you mind using this as a model?

#3363

There's more guidance on writing first timers only issues at code.publiclab.org as well.

Thank you so much!!!!!

@aSquare14

This comment has been minimized.

Show comment
Hide comment
@aSquare14

aSquare14 Sep 20, 2018

Member

Sure ! I'll format all the issues opened by me over the weekend ! :)

Member

aSquare14 commented Sep 20, 2018

Sure ! I'll format all the issues opened by me over the weekend ! :)

@jywarren

This comment has been minimized.

Show comment
Hide comment
@jywarren

jywarren Sep 21, 2018

Contributor
Contributor

jywarren commented Sep 21, 2018

@aSquare14

This comment has been minimized.

Show comment
Hide comment
@aSquare14

aSquare14 Sep 29, 2018

Member

So, for now I am just adding code snippet for removing line. Maybe we could open another issue where we can say redirect to page 2 @jywarren ?

Member

aSquare14 commented Sep 29, 2018

So, for now I am just adding code snippet for removing line. Maybe we could open another issue where we can say redirect to page 2 @jywarren ?

@jywarren

This comment has been minimized.

Show comment
Hide comment
@jywarren

jywarren Oct 4, 2018

Contributor
Contributor

jywarren commented Oct 4, 2018

@aSquare14

This comment has been minimized.

Show comment
Hide comment
@aSquare14

aSquare14 Oct 5, 2018

Member

Thanks for poiting it out. I'll look into it

Member

aSquare14 commented Oct 5, 2018

Thanks for poiting it out. I'll look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment