New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typo and UI Fix] in first time sign in at Dashboard Screen #3366

Closed
YashishDua opened this Issue Sep 20, 2018 · 11 comments

Comments

Projects
None yet
5 participants
@YashishDua
Contributor

YashishDua commented Sep 20, 2018

Pop up component error on the dashboard screen. [Text and its UI]
screen shot 2018-09-20 at 10 54 18 pm

When a user signs up for Public Lab and is landed on the home screen, pop up is shown at the top which has two errors:

  1. Typo in text
    Existing Text: You have successfully signed in. Please change your password via a link sent to you via a mail
    Updated Text: You have successfully signed in. Please change your password using the link sent to you via a mail
  2. The popup component is not full sized as compared to its relatively bottom placed popup of the welcome message

https://publiclab.org/ ...

@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot Sep 20, 2018

Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄

welcome bot commented Sep 20, 2018

Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄

@YashishDua YashishDua changed the title from [Typo and UI Fix] in First time sign in at Welcome Screen to [Typo and UI Fix] in first time sign in at Dashboard Screen Sep 20, 2018

@SidharthBansal

This comment has been minimized.

Show comment
Hide comment
@SidharthBansal

SidharthBansal Sep 21, 2018

Member

Are you willing to solve them?

Member

SidharthBansal commented Sep 21, 2018

Are you willing to solve them?

@bkocsis3

This comment has been minimized.

Show comment
Hide comment
@bkocsis3

bkocsis3 Sep 21, 2018

Contributor

I'm very new to this, but could I give it a try?

Contributor

bkocsis3 commented Sep 21, 2018

I'm very new to this, but could I give it a try?

@YashishDua

This comment has been minimized.

Show comment
Hide comment
@YashishDua

YashishDua Sep 21, 2018

Contributor

@bkocsis3 Yes, you can! It's for the first timers only.

Contributor

YashishDua commented Sep 21, 2018

@bkocsis3 Yes, you can! It's for the first timers only.

@SidharthBansal

This comment has been minimized.

Show comment
Hide comment
@SidharthBansal

SidharthBansal Sep 21, 2018

Member

@bkocsis3 go ahead.
Just remember that this issue has two parts. So solve them one by one.
Happy coding

Member

SidharthBansal commented Sep 21, 2018

@bkocsis3 go ahead.
Just remember that this issue has two parts. So solve them one by one.
Happy coding

@Suneet-M

This comment has been minimized.

Show comment
Hide comment
@Suneet-M

Suneet-M Sep 21, 2018

Can multiple people work on this issue? I'd like to try it too!

Suneet-M commented Sep 21, 2018

Can multiple people work on this issue? I'd like to try it too!

@namangupta01

This comment has been minimized.

Show comment
Hide comment
@namangupta01

namangupta01 Sep 21, 2018

Member

Hi @the-prolific-coder, this is not a big issue so it would be difficult for two people to work on it.
Please look for the other issues.

Member

namangupta01 commented Sep 21, 2018

Hi @the-prolific-coder, this is not a big issue so it would be difficult for two people to work on it.
Please look for the other issues.

@bkocsis3

This comment has been minimized.

Show comment
Hide comment
@bkocsis3

bkocsis3 Sep 21, 2018

Contributor

Awesome, thanks!

Contributor

bkocsis3 commented Sep 21, 2018

Awesome, thanks!

@bkocsis3

This comment has been minimized.

Show comment
Hide comment
@bkocsis3

bkocsis3 Sep 22, 2018

Contributor

This is a very noob question, but how do I find the file pertaining to this issue?

Contributor

bkocsis3 commented Sep 22, 2018

This is a very noob question, but how do I find the file pertaining to this issue?

@SidharthBansal

This comment has been minimized.

Show comment
Hide comment
@SidharthBansal

SidharthBansal Sep 22, 2018

Member

redirect_to root_url, notice: "You have successfully signed in. Please change your password via a link sent to you via a mail"

This might help

Member

SidharthBansal commented Sep 22, 2018

redirect_to root_url, notice: "You have successfully signed in. Please change your password via a link sent to you via a mail"

This might help

@YashishDua

This comment has been minimized.

Show comment
Hide comment
@YashishDua

YashishDua Sep 30, 2018

Contributor

@bkocsis3 is this Issue resolved?

Contributor

YashishDua commented Sep 30, 2018

@bkocsis3 is this Issue resolved?

@bkocsis3 bkocsis3 referenced this issue Sep 30, 2018

Merged

Fixed typos #3366 #3489

5 of 5 tasks complete

jywarren added a commit that referenced this issue Oct 1, 2018

Fixed typos #3366 (#3489)
* Fixed typos #3366

I changed "a mail" to "e-mail" on lines 51, 108, 165 and 221.

* Fixed typo in line 53

Changed "a mail" to "e-mail" in line 53.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment