New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorting button options to tag show template #3462

Open
first-timers bot opened this Issue Sep 25, 2018 · 11 comments

Comments

Projects
None yet
5 participants
@first-timers

first-timers bot commented Sep 25, 2018

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

This will add some nice buttons to tag pages such as these: https://publiclab.org/tag/mobius

Which will allow for sorting what's displayed!

screen shot 2018-09-25 at 11 58 38 am

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file app/views/tag/show.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -2,11 +2,11 @@
 
 <div class="col-md-12">
   <%= render partial: 'tag/show/header' %>
-  
+
   <% if @tags.first && params[:id][-1..-1] != "*" %>
-    <%= render :partial => "tag/graph", locals: { tags: @tags } %>
+    <%= render partial: "tag/graph", locals: { tags: @tags } %>
   <% end %>
-  
+
   <%= render partial: 'tag/show/contributors' %>
 
   <% unless @tags.try(:first).try(:parent).nil? %>
@@ -20,7 +20,10 @@
   <%= render partial: "tag/show/related_tags" %>
   <%= render partial: 'tag/show/nav_tabs' %>
   
-  <br />
+  <p style="padding-top:8px;">
+    <a class="btn btn-sm btn-default" href="?order=views"><i class="fa fa-eye"></i> by views</a>
+    <a class="btn btn-sm btn-default" href="?order=likes"><i class="fa fa-star"></i> by likes</a>
+  </p>
 
   <%= render partial: 'tag/show/tab_content' %>
 
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@jywarren

This comment has been minimized.

Show comment
Hide comment
@jywarren

jywarren Sep 25, 2018

Contributor

This will have to be merged AFTER #3419 -- thanks!!!

Contributor

jywarren commented Sep 25, 2018

This will have to be merged AFTER #3419 -- thanks!!!

@msarit

This comment has been minimized.

Show comment
Hide comment
@msarit

msarit Sep 25, 2018

Contributor

I'd like to tackle this issue - thanks! 🙏

Contributor

msarit commented Sep 25, 2018

I'd like to tackle this issue - thanks! 🙏

@jywarren

This comment has been minimized.

Show comment
Hide comment
@jywarren

jywarren Sep 25, 2018

Contributor
Contributor

jywarren commented Sep 25, 2018

@msarit msarit referenced a pull request that will close this issue Sep 25, 2018

Open

Add sorting button options to tag show template #3468

@msarit

This comment has been minimized.

Show comment
Hide comment
@msarit

msarit Sep 25, 2018

Contributor

Oh yes! I will do so - instead of hogging more first-timers issues 😂 Thanks Jeffrey.

Contributor

msarit commented Sep 25, 2018

Oh yes! I will do so - instead of hogging more first-timers issues 😂 Thanks Jeffrey.

@asiedubrempong

This comment has been minimized.

Show comment
Hide comment
@asiedubrempong

asiedubrempong Sep 25, 2018

I'd like to take this up as my first PR

asiedubrempong commented Sep 25, 2018

I'd like to take this up as my first PR

@jywarren

This comment has been minimized.

Show comment
Hide comment
@jywarren

jywarren Sep 25, 2018

Contributor

Please go ahead, @asiedubrempong !!

Contributor

jywarren commented Sep 25, 2018

Please go ahead, @asiedubrempong !!

@asiedubrempong

This comment has been minimized.

Show comment
Hide comment
@asiedubrempong

asiedubrempong commented Sep 25, 2018

sure thanks

@RishabhBhaai

This comment has been minimized.

Show comment
Hide comment
@RishabhBhaai

RishabhBhaai Oct 4, 2018

Can I work on this issue?
I want to contribute for the first time.

RishabhBhaai commented Oct 4, 2018

Can I work on this issue?
I want to contribute for the first time.

@agam-kashyap

This comment has been minimized.

Show comment
Hide comment
@agam-kashyap

agam-kashyap Oct 8, 2018

Hey, can I try to solve this if no one is already doing it?
THANKS.

agam-kashyap commented Oct 8, 2018

Hey, can I try to solve this if no one is already doing it?
THANKS.

@msarit

This comment has been minimized.

Show comment
Hide comment
@msarit

msarit Oct 8, 2018

Contributor

@RishabhBhaai are you still working on this? Please advise so that @agam-kashyap knows whether to take it up or not

Contributor

msarit commented Oct 8, 2018

@RishabhBhaai are you still working on this? Please advise so that @agam-kashyap knows whether to take it up or not

@agam-kashyap

This comment has been minimized.

Show comment
Hide comment
@agam-kashyap

agam-kashyap Oct 8, 2018

Thank You @msarit. Please do tell @RishabhBhaai

agam-kashyap commented Oct 8, 2018

Thank You @msarit. Please do tell @RishabhBhaai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment