New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notes_controller.rb #3669

Closed
first-timers bot opened this Issue Oct 10, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@first-timers

first-timers bot commented Oct 10, 2018

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file app/controllers/notes_controller.rb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -131,6 +131,7 @@ def create
           @node.add_tag('event:rsvp', current_user)
           @node.add_tag('date:' + params[:date], current_user) if params[:date]
         end
+        @node.add_tag('first-time-poster') if current_user.first_time_poster
         if params[:draft] != "true"
           if current_user.first_time_poster
             flash[:first_time_post] = true
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@jywarren

This comment has been minimized.

Show comment
Hide comment
@jywarren

jywarren Oct 10, 2018

Contributor

This one's for @quinn-codes-synthesis!!!

Contributor

jywarren commented Oct 10, 2018

This one's for @quinn-codes-synthesis!!!

@wendtbw

This comment has been minimized.

Show comment
Hide comment
@wendtbw

wendtbw Oct 11, 2018

Has this been claimed? Can I try it? Regards

wendtbw commented Oct 11, 2018

Has this been claimed? Can I try it? Regards

@quinn-codes-synthesis

This comment has been minimized.

Show comment
Hide comment
@quinn-codes-synthesis

quinn-codes-synthesis Oct 11, 2018

Contributor

Thanks jywarren! Yes wendtbw, it is claimed. :) I encourage you to look through other issues -- there's tons of stuff that needs doing!

Contributor

quinn-codes-synthesis commented Oct 11, 2018

Thanks jywarren! Yes wendtbw, it is claimed. :) I encourage you to look through other issues -- there's tons of stuff that needs doing!

@quinn-codes-synthesis quinn-codes-synthesis referenced this issue Oct 11, 2018

Merged

Update notes_controller.rb #3669 #3672

3 of 4 tasks complete
@quinn-codes-synthesis

This comment has been minimized.

Show comment
Hide comment
@quinn-codes-synthesis

quinn-codes-synthesis Oct 11, 2018

Contributor

#3672

Here's to hoping I did the pull request correctly. :)

Contributor

quinn-codes-synthesis commented Oct 11, 2018

#3672

Here's to hoping I did the pull request correctly. :)

jywarren added a commit that referenced this issue Oct 12, 2018

Update notes_controller.rb #3669 (#3672)
* Update notes_controller.rb

* update params on line 134 to include current_user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment