New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two pagination at the botton of the search page #3976

Closed
gptshubham595 opened this Issue Nov 15, 2018 · 8 comments

Comments

Projects
None yet
9 participants
@gptshubham595

gptshubham595 commented Nov 15, 2018

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

Problem: It can be found here i have just searched anything random

https://publiclab.org/search/hello

Here is a screenshot showing this:
search_error

##Solution
remove this line once

<%= will_paginate @tags, :renderer => BootstrapPagination::Rails unless @unpaginated %>

<%= will_paginate @tags, :renderer => BootstrapPagination::Rails unless @unpaginated %>

as this is repeated

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@Souravirus Souravirus changed the title from Two pagination ate the botton of the search page to Two pagination at the botton of the search page Nov 15, 2018

@ibrahimelbanna

This comment has been minimized.

Member

ibrahimelbanna commented Nov 15, 2018

Can I work on this?

@gauravano

This comment has been minimized.

Member

gauravano commented Nov 15, 2018

@ICEBERG98

This comment has been minimized.

Contributor

ICEBERG98 commented Nov 16, 2018

I want to work on this any too. Anything I can do?

@akoopraba4

This comment has been minimized.

akoopraba4 commented Nov 18, 2018

I would like to work on this issue.

@imsankalp

This comment has been minimized.

imsankalp commented Nov 21, 2018

If this issue is not taken by anyone, I would like to solve it.

@SidharthBansal

This comment has been minimized.

Member

SidharthBansal commented Nov 21, 2018

Are you @ibrahimelbanna working on this? if not please tell. If yes please open up a pull request.

@sashadev-sky

This comment has been minimized.

Contributor

sashadev-sky commented Dec 5, 2018

@publiclab/reviewers I believe this issue was resolved 4 days ago by PR #4089 and can be closed

@SidharthBansal

This comment has been minimized.

Member

SidharthBansal commented Dec 6, 2018

@sashadev-sky I could not see the error reported in the issue on the main production website. So I think we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment