New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recenter 'Read more' button for note previews #4113

Closed
sashadev-sky opened this Issue Dec 4, 2018 · 18 comments

Comments

Projects
None yet
8 participants
@sashadev-sky
Contributor

sashadev-sky commented Dec 4, 2018

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

The problem

The 'notes' previews across the site are aligned right instead of centered!
https://publiclab.org/search/notes/balloon

screen shot 2018-12-03 at 10 47 06 pm

Solution

This is a pretty easy one -- let's remove the CSS declarations from the notes HTML file that are overwriting the button's previously centered alignment:

Delete line 69 (and line 70, which is overwritten by the declaration directly under it anyway):

<style>
.content {
width: 100px;
margin-left: auto;
margin-bottom: 0;
margin-bottom: 30%;
</style>

Delete the entire inline style attribute.

<a class="btn btn-default" style="float: right; margin-left: 1px;" href="<%= node.path %>"><%= t('notes._notes.read_more') %></a>

Thanks!!

Steps to Fix

  • Claim this issue with a comment here, below, and ask any clarifying questions you need
  • Fork the repository and set it up locally following the main repo README instructions https://github.com/publiclab/plots2
  • Create a new feature branch with a unique name descriptive to the issue
  • Try to fix the issue following the steps above, but even before you're done, you can:
    commit your changes to your branch and start a pull request (see contributing to Public Lab software) but mark it as "in progress" if you have questions or if you haven't finished
  • Reference this issue in the pull request body
  • Once you submit your pull request, an additional checklist will be provided for getting it merged

💬 Get help

If you need any help - here are some options:

@sashadev-sky sashadev-sky changed the title from Re-center Read more button for a note preview to Re-center Read more button for note previews Dec 4, 2018

@sashadev-sky sashadev-sky changed the title from Re-center Read more button for note previews to Re-center 'Read more' button for note previews Dec 4, 2018

@sashadev-sky sashadev-sky changed the title from Re-center 'Read more' button for note previews to Recenter 'Read more' button for note previews Dec 4, 2018

@rachelkam5

This comment has been minimized.

rachelkam5 commented Dec 5, 2018

Hi! I would love to contribute to this issue. This would be my very first open source contribution.

@rachelkam5

This comment has been minimized.

rachelkam5 commented Dec 5, 2018

I just read over your README file, and I have a question about #4 under Standard Installation. I've never worked with Rails before, so I'm not sure about the rails root directory. Do I need to install Rails or something else before setting up the fork locally? Thank you!

@sashadev-sky

This comment has been minimized.

Contributor

sashadev-sky commented Dec 5, 2018

@rachelkam5 we would love your help on this!

The root directory of any project refers to the top-level directory - in this case the same place where the Gemfile is located. Since Rails is the framework used for plots2, the README is just referring to the whole project as 'rails' and saying run the command from its root directory.

Rails is available as a gem in the Gemfile so running the provided bundle install command should setup everything you need :)

Let me know if that helps!

@rachelkam5

This comment has been minimized.

rachelkam5 commented Dec 5, 2018

@sashadev-sky Thank you! I will get to work and let you know if I have any more questions!

@sashadev-sky

This comment has been minimized.

Contributor

sashadev-sky commented Dec 5, 2018

Sounds good 👍

@rachelkam5

This comment has been minimized.

rachelkam5 commented Dec 5, 2018

Hi @sashadev-sky I'm so sorry, but I don't think I'm cut out for this one. I've spent a really long time trying to install Ubuntu, Bash, RVM, etc. and I'm getting error after error. I'm so sorry!

@sashadev-sky

This comment has been minimized.

Contributor

sashadev-sky commented Dec 5, 2018

@rachelkam5 Don't worry!! Ask as many questions as you'd like, thats what this issue is for :)

I received a lot of errors my first time setting up the repo as well. Maybe I can take a look at yours? Feel free to message me in the Gitter chatroom if you prefer.

@jywarren

This comment has been minimized.

Contributor

jywarren commented Dec 6, 2018

Yes, and there are some discussions on common install issues over at #3840 -- maybe that can help too!

@wanzulfikri

This comment has been minimized.

Contributor

wanzulfikri commented Dec 6, 2018

@rachelkam5 Can I take a stab at this? If you are still working on this, do continue.

@rachelkam5

This comment has been minimized.

rachelkam5 commented Dec 6, 2018

@wanzulfikri Yes, please take over! Thank you!

@wanzulfikri

This comment has been minimized.

Contributor

wanzulfikri commented Dec 6, 2018

@rachelkam5 Thanks! I’ll try to do it.

I’m a bit slow, so if anyone wants to do it and can complete it earlier than I, feel free to do it and submit the pull request.

@uzorjchibuzor

This comment has been minimized.

Contributor

uzorjchibuzor commented Dec 6, 2018

@wanzulfikri

How far along are you? I also want to take a stab at this.

@wanzulfikri

This comment has been minimized.

Contributor

wanzulfikri commented Dec 6, 2018

@uzorjchibuzor

Honestly - zero progress.

You can try if you want.

I don’t own it haha.

@navkumar2245

This comment has been minimized.

navkumar2245 commented Dec 7, 2018

can i work on this issue if not fixed.

@SidharthBansal

This comment has been minimized.

Member

SidharthBansal commented Dec 7, 2018

We have a PR. Please look for other issues

@SidharthBansal

This comment has been minimized.

Member

SidharthBansal commented Dec 7, 2018

@sashadev-sky
please use permalinks instead of line numbers. They are adjusted as the other changes are merged by other users..

@SidharthBansal

This comment has been minimized.

Member

SidharthBansal commented Dec 7, 2018

Solved in #4146

@sashadev-sky

This comment has been minimized.

Contributor

sashadev-sky commented Dec 8, 2018

@SidharthBansal thank you for taking over here :) noted about the line numbers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment