New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbars should be on the same horizontal line #4189

Open
oorjitchowdhary opened this Issue Dec 8, 2018 · 16 comments

Comments

Projects
None yet
5 participants
@oorjitchowdhary
Copy link
Collaborator

oorjitchowdhary commented Dec 8, 2018

Hi, this is a first-timers-only issue made from #4163. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file profile.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Issue

The navbar tabs are currently spread out in 2 lines, whereas it should be on the one same horizontal line.

image

Code link

https://github.com/publiclab/plots2/blob/master/app/views/users/profile.html.erb#L43-L119

Solution

This can be solved by using Bootstrap classes to hide the text (leaving
only the icon) for narrower width screens!

You can visit https://getbootstrap.com/docs/3.3/ for reference.

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

@oorjitchowdhary

This comment has been minimized.

Copy link
Collaborator

oorjitchowdhary commented Dec 8, 2018

@publiclab/mentors I can't add labels.. pls add the first-timers-only label..

@SidharthBansal

This comment has been minimized.

Copy link
Member

SidharthBansal commented Dec 8, 2018

Thanks. @oorjitchowdhary please provide complete solution. Through first timers we want to teach new comers git basics and our workflow pattern

@professionalzack

This comment has been minimized.

Copy link

professionalzack commented Dec 9, 2018

I would like to work on this issue thanks

@professionalzack

This comment has been minimized.

Copy link

professionalzack commented Dec 9, 2018

i am not exactly sure how to share the PR in here, but i've made one. here is the link (i think):
professionalzack#1

@arungoel123456

This comment has been minimized.

Copy link

arungoel123456 commented Dec 9, 2018

Can I work on this issue please

@oorjitchowdhary

This comment has been minimized.

Copy link
Collaborator

oorjitchowdhary commented Dec 9, 2018

@arungoel123456 I think @professionalzack is working on it..

@arungoel123456

This comment has been minimized.

Copy link

arungoel123456 commented Dec 9, 2018

So i can't do it ?? If i can't , can u please provide me some first - timer's issue which i can

@arungoel123456

This comment has been minimized.

Copy link

arungoel123456 commented Dec 9, 2018

@professionalzack are u working on it ??

@oorjitchowdhary

This comment has been minimized.

Copy link
Collaborator

oorjitchowdhary commented Dec 9, 2018

@arungoel123456 @professionalzack If you guys are willing to collaborate this one.. you're most welcome.. 😃
Otherwise, @arungoel123456 you can check out https://github.com/publiclab/plots2/issues?q=is%3Aissue+is%3Aopen+label%3Afirst-timers-only for issues which are meant to be solved by first-timers..

Welcome to Public Lab! 🎉

@arungoel123456

This comment has been minimized.

Copy link

arungoel123456 commented Dec 9, 2018

@professionalzack would u like to collaborate

@oorjitchowdhary

This comment has been minimized.

Copy link
Collaborator

oorjitchowdhary commented Dec 9, 2018

i am not exactly sure how to share the PR in here, but i've made one. here is the link (i think):
professionalzack#1

@professionalzack I just took a look here.. You actually created a pull request in your own fork of the repository..

You've to commit changes in the publiclab/plots2 repository.. To do that here are the steps you can follow.. And ping me on the pull request if you've any doubts.. Thanks a lot..

  • 💾 Commit your changes
  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:
  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
  2. You can also edit files directly in your browser and open a pull request from there.
@SidharthBansal

This comment has been minimized.

Copy link
Member

SidharthBansal commented Dec 9, 2018

@arungoel123456 as this is a small task, you should take another issue and let @professionalzack work on this one alone

professionalzack added a commit to professionalzack/plots2 that referenced this issue Dec 11, 2018

Merge pull request #1 from professionalzack/issue-4189-navbar
Issue publiclab#4189 - Updated Bootstrapping on Navbar

professionalzack added a commit to professionalzack/plots2 that referenced this issue Dec 11, 2018

@professionalzack professionalzack referenced a pull request that will close this issue Dec 11, 2018

Open

Updated Bootstrapping on Navbar #4262

4 of 4 tasks complete
@professionalzack

This comment has been minimized.

Copy link

professionalzack commented Dec 11, 2018

Hi sorry, I have been out of the house. I had a couple confusions here but seemed to have squared it away. Just waiting to see if the PR is accepted.
Thanks !

@rexagod

This comment has been minimized.

Copy link
Contributor

rexagod commented Dec 12, 2018

Hey I'd like to claim this issue please!

@oorjitchowdhary

This comment has been minimized.

Copy link
Collaborator

oorjitchowdhary commented Dec 12, 2018

@rexagod I think @professionalzack may have already solved this one..
You can take a look at #4270 if you want.. Else go to https://github.com/publiclab/plots2/labels/first-timers-only for all the first timers only issue..
Thanks

@rexagod

This comment has been minimized.

Copy link
Contributor

rexagod commented Dec 12, 2018

@oorjitchowdhary I've submitted a claim request at #4270 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment