New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the extra space after `share` #4611

Closed
oorjitchowdhary opened this Issue Jan 14, 2019 · 5 comments

Comments

Projects
None yet
5 participants
@oorjitchowdhary
Copy link
Collaborator

oorjitchowdhary commented Jan 14, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file app/views/editor/rich.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

    <!-- errors module -->
    <div class="ple-module container">
    <div class="col-md-3"></div>
    <div class="ple-errors col-md-9"></div>
    </div>
    <!-- end errors module -->

Remove the extra space which is below the share button text.

screenshot 152

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

- <div class="ple-module container"> 
-
-  <div class="col-md-3"></div> 
-  <div class="ple-errors col-md-9"></div> 

+  <div class="ple-errors"></div> 
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

@JAIDEV123

This comment has been minimized.

Copy link
Contributor

JAIDEV123 commented Jan 14, 2019

On it!

JAIDEV123 added a commit to JAIDEV123/plots2 that referenced this issue Jan 14, 2019

@JAIDEV123 JAIDEV123 referenced this issue Jan 14, 2019

Merged

Removed Extra Space after 'Share' #4612

5 of 5 tasks complete

JAIDEV123 added a commit to JAIDEV123/plots2 that referenced this issue Jan 14, 2019

@Gonnuru

This comment has been minimized.

Copy link

Gonnuru commented Jan 19, 2019

Im claiming this issue. Has anyone else claimed it ? If you have have you created a pull request already ? If your stuck I guess I can help you.

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Jan 19, 2019

Hi @Gonnuru, a PR by @JAIDEV123 is already in progress at #4612 so please find another issue and seems like @JAIDEV123 is stuck with ruby version problem so you can surely help by coordinating with them in the PR. Thanks!

@rohanpalhappy

This comment has been minimized.

Copy link

rohanpalhappy commented Feb 9, 2019

I am taking up this issue.

@rohanpalhappy rohanpalhappy referenced this issue Feb 9, 2019

Closed

Removed Extra Space after 'Share' #4783

5 of 5 tasks complete
@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Feb 10, 2019

The issue already has PR, so please look for another issues to solve. You can explore FTO issues at https://code.publiclab.org/#r=all and if you can't find one there, feel free to comment here, we'll try to open one for you. Thanks!

jywarren added a commit that referenced this issue Feb 15, 2019

Removed Extra Space after 'Share' (#4612)
* Removed Extra Sprace after 'Share'

Fixes Issue : #4611

* Update rich.html.erb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment