New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Tag Subscription on Email footers 2 #4663

Closed
geekychaser opened this Issue Jan 19, 2019 · 15 comments

Comments

Projects
None yet
7 participants
@geekychaser
Copy link
Contributor

geekychaser commented Jan 19, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

Problem

Add multiple tag Subscription on email footers

📋Solution

Add line

<p>Subscribe to all the tags for this post by visiting https://<%= ActionMailer::Base.default_url_options[:host] %>/subscribe/multiple/tag/<%= @tags %>.</p>

to

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@geekychaser

This comment has been minimized.

Copy link
Contributor Author

geekychaser commented Jan 19, 2019

@SidharthBansal please add the labels and milestone

@Gonnuru

This comment has been minimized.

Copy link

Gonnuru commented Jan 19, 2019

@geekychaser can I claim this issue ? As I'm a first timer and am looking for an open source contribution

@SidharthBansal

This comment has been minimized.

Copy link
Member

SidharthBansal commented Jan 19, 2019

@Gonnuru you can do this.

@SidharthBansal

This comment has been minimized.

Copy link
Member

SidharthBansal commented Jan 19, 2019

Best of luck

@Gonnuru

This comment has been minimized.

Copy link

Gonnuru commented Jan 19, 2019

@SidharthBansal Thanks a lot 😃

@Gonnuru

This comment has been minimized.

Copy link

Gonnuru commented Jan 19, 2019

@geekychaser @SidharthBansal Kindly go through my pull request and check if I have been able to branch properly and also name the branch in a correct way. Apart from that have I met the Issue criteria.

@SidharthBansal

This comment has been minimized.

Copy link
Member

SidharthBansal commented Jan 19, 2019

You have to create PR in plots2 repository. Not in your own.

@Gonnuru

This comment has been minimized.

Copy link

Gonnuru commented Jan 20, 2019

You have to create PR in plots2 repository. Not in your own.

sure will do that

@Gonnuru

This comment has been minimized.

Copy link

Gonnuru commented Jan 20, 2019

@SidharthBansal I have added to plots2 repository kindly check it once

@SidharthBansal

This comment has been minimized.

Copy link
Member

SidharthBansal commented Jan 20, 2019

I cannot find it. You have to create PR in https://github.com/publiclab/plots2 so it will me present in https://github.com/publiclab/plots2/pulls

@geekychaser

This comment has been minimized.

Copy link
Contributor Author

geekychaser commented Jan 20, 2019

@Gonnuru You have to post a PR for publiclab/plots2 but it seems like you have posted one on your forked one.
thank you

@snpd25

This comment has been minimized.

Copy link
Contributor

snpd25 commented Jan 27, 2019

@SidharthBansal , If not already solved can I work on this issue?

@SidharthBansal

This comment has been minimized.

Copy link
Member

SidharthBansal commented Jan 27, 2019

@IshaGupta18

This comment has been minimized.

Copy link
Collaborator

IshaGupta18 commented Feb 11, 2019

I think this issue is done, so I am closing it. Great work 🎉

@SidharthBansal

This comment has been minimized.

Copy link
Member

SidharthBansal commented Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment