New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "&" HTML Entity #4681

Open
rexagod opened this Issue Jan 21, 2019 · 11 comments

Comments

Projects
None yet
8 participants
@rexagod
Copy link
Collaborator

rexagod commented Jan 21, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update: There are many instances of code containing "&" to implement the "&" character in the website, but instead it renders the "&" string itself.

screenshot from 2019-01-22 01-30-28

In order to resolve this, we can replace the following "&" instances by "and".

./app/views/editor/_editor.html.erb:
   17:           Drag & drop to add an image or file, or 

./app/views/editor/_main_image.html.erb:
   17:         Drag & drop to add an image, or 

./config/locales/views/comments/_edit/en.yml:
    7:       drag_and_drop: "Drag & drop to add an image or file, or"

./config/locales/views/comments/_form/en.yml:
    7:       drag_and_drop: "Drag & drop to add an image or file, or"

./config/locales/views/users/_photo/en.yml:
    7:       drag_and_drop_image: "Drag & drop to add an image, or"
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

@Chrisyee22

This comment has been minimized.

Copy link

Chrisyee22 commented Jan 22, 2019

Can I work on this?

@rexagod

This comment has been minimized.

Copy link
Collaborator Author

rexagod commented Jan 22, 2019

Hey @Chrisyee22! Sure, go ahead!

@prashant0598

This comment has been minimized.

Copy link

prashant0598 commented Jan 23, 2019

@rexagod Can I work on this issue if it is not claimed.

@rexagod

This comment has been minimized.

Copy link
Collaborator Author

rexagod commented Jan 23, 2019

Sure, go ahead @prashant0598!!

@Chrisyee22 Chrisyee22 referenced a pull request that will close this issue Jan 23, 2019

Open

Replace &amp #4700

0 of 2 tasks complete
@arungoel123456

This comment has been minimized.

Copy link

arungoel123456 commented Jan 24, 2019

Can i work on this issue?

@rexagod

This comment has been minimized.

Copy link
Collaborator Author

rexagod commented Jan 24, 2019

Sorry @arungoel123456, it looks like @Chrisyee22 has already submitted a PR. But you can go ahead and checkout other first timer issues in the meantime. Thanks!

@RizwanSyed357

This comment has been minimized.

Copy link

RizwanSyed357 commented Feb 10, 2019

Hi, Is anyone still working on this? If not, I'd be keen. First timer here :)

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Feb 10, 2019

Hi @RizwanSyed357, this one has a PR in #4700 and I think you have already started work on another FTO issue, so let's complete that for now. Thanks!

@RizwanSyed357

This comment has been minimized.

Copy link

RizwanSyed357 commented Feb 10, 2019

@gauravano Thanks for that

@ShazZaman

This comment has been minimized.

Copy link

ShazZaman commented Feb 10, 2019

Hello Guys, is anybody currently working on this issue?

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Feb 12, 2019

Hi @ShazZaman, this issue has a PR in progress at #4700. You can find more FTO issues at https://code.publiclab.org/#r=all and if you don't see any unclaimed there, then feel free to comment here, we'll try to open an issue for you. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment