Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align download as buttons on smaller screens #4972

Closed
cesswairimu opened this Issue Mar 9, 2019 · 22 comments

Comments

Projects
None yet
5 participants
@cesswairimu
Copy link
Collaborator

cesswairimu commented Mar 9, 2019

Created specifically for @karunagoyalk

馃 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

馃搵 Step by Step

  • 馃檵 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 馃摑 Update:
    At https://publiclab.org/stats the download as buttons are not well aligned(To see this locally login as admin) are not aligned well on smaller screens.
    download

https://github.com/publiclab/plots2/blob/master/app/views/stats/_range.html.erb#L32-L94

Update

 <div class="row">
 <div class="col-md-4 col-md-offset-2">
</div>
&emsp;
<div class="col-md-3">
 </div>
</div>

After changing the view, also attach the screenshot of updated view in the PR. (You probably have to go on responsive design mode by pressing Ctrl+shift+M)

  • 馃捑 Commit your changes

  • 馃攢 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 馃弫 Done Ask in comments for a review :)

馃 Questions?

Leave a comment below!

@cesswairimu

This comment has been minimized.

Copy link
Collaborator Author

cesswairimu commented Mar 9, 2019

@karunagoyalk here you go

@GettyOrawo

This comment has been minimized.

Copy link
Contributor

GettyOrawo commented Mar 9, 2019

Hello @cesswairimu has is this issue already claimed?

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Mar 9, 2019

Hey @GettyOrawo, this issue was created for @karunagoyalk as they were searching for an issue to take on. Are you looking for a FTO?

@karunagoyalk

This comment has been minimized.

Copy link
Contributor

karunagoyalk commented Mar 9, 2019

@cesswairimu @gauravano thanks! I will work on it

@helenatxu

This comment has been minimized.

Copy link

helenatxu commented Mar 12, 2019

Hi I am an Outreachy applicant, could I be assigned to this issue to work on? Or maybe you have another issue you could assign me to start working :) Thanks @gauravano

@gauravano gauravano added the assigned label Mar 12, 2019

@cesswairimu

This comment has been minimized.

Copy link
Collaborator Author

cesswairimu commented Mar 16, 2019

Hi @karunagoyalk how is this coming along?

@karunagoyalk

This comment has been minimized.

Copy link
Contributor

karunagoyalk commented Mar 16, 2019

@cesswairimu hey! Actually i faced some problem while installing and building the project.But I am trying , i will get back to you in some time with PR

@cesswairimu

This comment has been minimized.

Copy link
Collaborator Author

cesswairimu commented Mar 16, 2019

Okay cool. rem to checkout #3840 to see if there are any issues you are getting that was solved there or add a comment with your error and we can try and help

@karunagoyalk

This comment has been minimized.

Copy link
Contributor

karunagoyalk commented Mar 17, 2019

Hey! @cesswairimu I have mailed for Free invite for cloud9, But I did not get any response yet!

@cesswairimu

This comment has been minimized.

Copy link
Collaborator Author

cesswairimu commented Mar 17, 2019

Hey @karunagoyalk Not sure accepts the access requests for c9 but let me find out. Did you have installations problems? Maybe you can edit it on github and I will help add the screenshot for you?

@karunagoyalk

This comment has been minimized.

Copy link
Contributor

karunagoyalk commented Mar 17, 2019

Hey! @cesswairimu I have done the editing on github! please help me in adding screenshot.

@cesswairimu

This comment has been minimized.

Copy link
Collaborator Author

cesswairimu commented Mar 17, 2019

cool, on it

@cesswairimu

This comment has been minimized.

Copy link
Collaborator Author

cesswairimu commented Mar 17, 2019

Hey @karunagoyalk could you create a new branch.
go here
Screenshot from 2019-03-17 21-38-51

and type fix-download-buttons when the create blue highlight comes click on it..so we can make a pull request from that branch. Thanks

@karunagoyalk

This comment has been minimized.

Copy link
Contributor

karunagoyalk commented Mar 18, 2019

Hey @cesswairimu I have created the branch,as per you suggested me to do!

@cesswairimu

This comment has been minimized.

Copy link
Collaborator Author

cesswairimu commented Mar 18, 2019

Awesome seen it...one last thing I want you to make the pull request. just go here https://github.com/karunagoyalk/plots2/tree/Fix-download-buttons then click the Compare button on the right side. Then just click the create pull request green button then we are set

@karunagoyalk

This comment has been minimized.

Copy link
Contributor

karunagoyalk commented Mar 18, 2019

Hey @cesswairimu what is this?
Screenshot

@karunagoyalk

This comment has been minimized.

Copy link
Contributor

karunagoyalk commented Mar 18, 2019

@cesswairimu Hey! I am new to open source, please help me , what to do here as I have not added any Screenshot
Screenshot from 2019-03-18 20-09-45

@cesswairimu

This comment has been minimized.

Copy link
Collaborator Author

cesswairimu commented Mar 18, 2019

I will add it for you just now...awesome creating a pull request 馃帀

@cesswairimu

This comment has been minimized.

Copy link
Collaborator Author

cesswairimu commented Mar 18, 2019

Hey @karunagoyalk added the screenshot and left a comment. You can edit this by going here https://github.com/publiclab/plots2/pull/5152/files an then hit the edit kaykay
and change line 33 to <div class="col-md-4 col-md-offset-1"> after that just commit then we are ready. Thanks

@karunagoyalk

This comment has been minimized.

Copy link
Contributor

karunagoyalk commented Mar 18, 2019

@cesswairimu Hey! thanks alot for helping me in creating my first PR.I have done the final editing, Can you please have a look,Let me know!

@karunagoyalk

This comment has been minimized.

Copy link
Contributor

karunagoyalk commented Mar 18, 2019

@cesswairimu Hey! Can you assign me some other issue to work on?

@cesswairimu

This comment has been minimized.

Copy link
Collaborator Author

cesswairimu commented Mar 18, 2019

Hey @karunagoyalk you can through these issues https://github.com/publiclab/plots2/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22 and see if there is an issue you can work on. Feel free to ping me if you get stuck. Also I would suggest you install the code locally or have it set on C9 for easier testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.