Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove background from wiki links shown on profile sidebar #4980

Open
gauravano opened this Issue Mar 9, 2019 · 25 comments

Comments

Projects
None yet
5 participants
@gauravano
Copy link
Member

gauravano commented Mar 9, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update:
    On /profile/[username] in the sidebar, links display colored background on hover, let's remove the background color from the links

Screenshot from 2019-03-10 03-14-29

Update this line of code
https://github.com/publiclab/plots2/blob/master/app/views/users/profile.html.erb#L284
so that on hovering over the links, no color is shown.

Also, try to shift the icon in the colored zone and upload the screenshot asking which view is looking better?

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

@gauravano

This comment has been minimized.

Copy link
Member Author

gauravano commented Mar 9, 2019

This issue is created for @EngrEric. Thanks!

@gauravano gauravano referenced this issue Mar 9, 2019

Open

Improve view of /notes page #4937

0 of 5 tasks complete
@EngrEric

This comment has been minimized.

Copy link

EngrEric commented Mar 9, 2019

Thanks, I will be working on it

@EngrEric

This comment has been minimized.

Copy link

EngrEric commented Mar 10, 2019

@gauravano, I am trying to setup the project locally on my computer but has this error
Gem::LoadError: mysql2 is not part of the bundle. Add it to your Gemfile.

@gauravano

This comment has been minimized.

Copy link
Member Author

gauravano commented Mar 11, 2019

Hi @EngrEric, we are working on solving this issue. You can try some temporary fixes given here - #4936 in the meantime. Sorry for the inconvenience.

@EngrEric

This comment has been minimized.

Copy link

EngrEric commented Mar 13, 2019

@gauravano see what i have
image
image

@EngrEric

This comment has been minimized.

Copy link

EngrEric commented Mar 13, 2019

@gauravano please is there a slack channel here

@luanafaustini

This comment has been minimized.

Copy link
Contributor

luanafaustini commented Mar 13, 2019

Hello,I would like to help with this or any other issue.
@EngrEric can I help you with something? I'm new at HTML and CSS, but I'm sure can try my best.

@gauravano Would you like to create an issue for me?

Thank you!

@gauravano

This comment has been minimized.

Copy link
Member Author

gauravano commented Mar 13, 2019

Hi @EngrEric, please update your fork as this issue is recently resolved.

@luanafaustini you can start working on #5051. Thanks!

@EngrEric

This comment has been minimized.

Copy link

EngrEric commented Mar 15, 2019

@gauravano is there another issue i should work on?

@gauravano

This comment has been minimized.

Copy link
Member Author

gauravano commented Mar 15, 2019

have you raised fix for this issue? @EngrEric

@EngrEric

This comment has been minimized.

Copy link

EngrEric commented Mar 15, 2019

@gauravano, no.
What are the steps to raise the fix.
To open a pull request?
Again, I am still having mysql2... issue...
So my local branch is still not working

@gauravano

This comment has been minimized.

Copy link
Member Author

gauravano commented Mar 15, 2019

Rebase your local branch with master as fix for the issue is already merged

@EngrEric

This comment has been minimized.

Copy link

EngrEric commented Mar 15, 2019

@gauravano Do I still have to present it as my contribution at outreachy or you will create another one for me.

@gauravano

This comment has been minimized.

Copy link
Member Author

gauravano commented Mar 15, 2019

You have to solve this or another issue and submit it at outreachy portal

@EngrEric

This comment has been minimized.

Copy link

EngrEric commented Mar 15, 2019

Cool, in want to solve this one.
@gauravano thanks for your help so far.
My greatest challenge is to get this run on my local machine.
The fix will not be hard for me.
At least am about 6 months older developer world.

@gauravano

This comment has been minimized.

Copy link
Member Author

gauravano commented Mar 15, 2019

Great! Give it a try and if you get stuck on updating PR branch then let me know. Thanks!

@EngrEric

This comment has been minimized.

Copy link

EngrEric commented Mar 19, 2019

@gauravano i have fixed this issue.
this is my solution.
please take a look at it

image

@EngrEric EngrEric referenced a pull request that will close this issue Mar 19, 2019

Open

remove background from wiki links shown on profile sidebar #5166

5 of 5 tasks complete
@Priyak5

This comment has been minimized.

Copy link

Priyak5 commented Mar 19, 2019

Hello! I would like to work on this if not solved or any other first timer issue. I have experience in HTML and CSS through school projects and will try my best.
@gauravano is there any issue I can work on?
Any help is appreciated!
Thank you!

@gauravano

This comment has been minimized.

Copy link
Member Author

gauravano commented Mar 19, 2019

Hi @Priyak5, I have added your name to #4963 (comment) and will ping you soon with a new/appropriate issue. Thanks!

@vaarigupta

This comment has been minimized.

Copy link

vaarigupta commented Mar 19, 2019

hello @gauravano I am an outreachy applicant and excited to work on this issue. How can I start contributing ?

@gauravano

This comment has been minimized.

Copy link
Member Author

gauravano commented Mar 20, 2019

Hey @vaarigupta, you can start working on this #5191 . Thanks!

@vaarigupta

This comment has been minimized.

Copy link

vaarigupta commented Mar 21, 2019

I

Hey @vaarigupta, you can start working on this #5191 . Thanks!

Ya sure I look into it
Thanks @gauravano

@EngrEric

This comment has been minimized.

Copy link

EngrEric commented Mar 22, 2019

@gauravano
please i think you are my mentor here.
your attention is needed here.
Please work with your mentor to provide a timeline of the work you plan to accomplish on the project and what tasks you will finish at each step. Make sure take into account any time commitments you have during the Outreachy internship round. If you are still working on your contributions and need more time, you can leave this blank and edit your application later.

@EngrEric

This comment has been minimized.

Copy link

EngrEric commented Mar 22, 2019

@gauravano .
THIS IS THE TASK I WANT TO WORK ON DURING THE INTERNSHIP
Modifying the People page to show a map on the right side
how do make a timeline for it as wanted by outreachy

@gauravano

This comment has been minimized.

Copy link
Member Author

gauravano commented Mar 24, 2019

Hi @EngrEric, you have to make a timeline where you'll be mentioning which tasks(from #4922) you'll be doing in each week. Also, dedicate some time to testing with each week if you think that week's task requires it. Or, you can plan for tests at end (if testing is required)

Start making a timeline in your proposal and I or some other mentor will review and suggest the changes. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.