Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the UI of readmore blogs button #4990

Open
CleverFool77 opened this Issue Mar 10, 2019 · 13 comments

Comments

Projects
None yet
5 participants
@CleverFool77
Copy link
Member

CleverFool77 commented Mar 10, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update .

  • Change the UI of Readmore button so that it can be differentiated from individual notes Readmore button.

Screenshot from 2019-03-10 20-34-04

  • Update will be done in plots2/app/views/home/home.html.erb
  • Go for a design similar as given image in ask a question button but smaller in size.

Screenshot from 2019-03-10 23-08-48

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@CleverFool77

This comment has been minimized.

Copy link
Member Author

CleverFool77 commented Mar 10, 2019

@gauravano Is this issue correct ?

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Mar 10, 2019

You have to add link to the line of code new contributor has to modify and what should be the new design.

@CleverFool77

This comment has been minimized.

Copy link
Member Author

CleverFool77 commented Mar 10, 2019

Ohk. I'll add it.

@CleverFool77

This comment has been minimized.

Copy link
Member Author

CleverFool77 commented Mar 10, 2019

@gauravano Updated the issue :)

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Mar 11, 2019

@coderbeetle interested in solving this one? Thanks!

@kuja24

This comment has been minimized.

Copy link

kuja24 commented Mar 12, 2019

@gauravano Can I work on this one?

@gauravano gauravano added the assigned label Mar 12, 2019

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Mar 12, 2019

hey @kuja24, this issue is assigned to @coderbeetle as they're waiting for their first-issue for some time. I have added your name to #4963 and we'll ping you soon with a FTO. Thanks!

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Mar 12, 2019

You can also start with other help-wanted issues, and if face doubts, feel free to ask us. Thanks!

@Aarabhi2017

This comment has been minimized.

Copy link

Aarabhi2017 commented Mar 13, 2019

Hi @gauravano , Could you please add me as well? I would like to work on a FTO too

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Mar 13, 2019

Hey @Aarabhi2017, added your name too 👍

@coderbeetle

This comment has been minimized.

Copy link

coderbeetle commented Mar 14, 2019

Ah, sorry I haven't been on here for a few days! An emergency with my cat occurred and I've been busy with frequent visits to the vet. I'll look into the issue very soon! Thank you and sorry for the inconvenience :)

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Mar 14, 2019

No issue!

@coderbeetle coderbeetle referenced a pull request that will close this issue Mar 14, 2019

Open

'Read More' button UI Improvement #5064

5 of 5 tasks complete
@coderbeetle

This comment has been minimized.

Copy link

coderbeetle commented Mar 14, 2019

I made a pull request on the issue, could it please get reviewed? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.