Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add css to set width of tooltip #5045

Open
ananyaarun opened this Issue Mar 13, 2019 · 9 comments

Comments

Projects
None yet
3 participants
@ananyaarun
Copy link
Member

ananyaarun commented Mar 13, 2019

Refer #5027
Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file wiki.css in the plots2 repository to add css for the tooltip.
    Added css should set the maximun width of the tooltip.
    Code of this format can be followed -

.tooltip-inner { max-width: 500px }

See this page for some help in taking your first steps!

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

@ananyaarun

This comment has been minimized.

Copy link
Member Author

ananyaarun commented Mar 13, 2019

@gauravano , This is the second part of fixing #5027 . I'm not sure where the new css can be added and some experimenting needs to be done on the width. For now i'm adding css in wiki.css let me know if it should be added in another file.

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Mar 13, 2019

@aggarwal19 you can work on this one. Thanks!

@gauravano gauravano added the assigned label Mar 13, 2019

@aggarwal19

This comment has been minimized.

Copy link

aggarwal19 commented Mar 14, 2019

Okay ,I'm working on it .
Thanks

@ananyaarun

This comment has been minimized.

Copy link
Member Author

ananyaarun commented Mar 19, 2019

@aggarwal19 , How's this issue going ? Do u need any help :) ?

@aggarwal19

This comment has been minimized.

Copy link

aggarwal19 commented Mar 20, 2019

@ananyaarun

This comment has been minimized.

Copy link
Member Author

ananyaarun commented Mar 20, 2019

No problem Good luck :) !!

@aggarwal19 aggarwal19 referenced a pull request that will close this issue Mar 21, 2019

Open

Add css to set width of tooltip #5214

4 of 5 tasks complete
@aggarwal19

This comment has been minimized.

Copy link

aggarwal19 commented Mar 21, 2019

@gauravano Hi ,I want to ask that which version of ruby we have to use in this project?
because the documentation provided on public lab repository said that we have to use ruby2.3 but when i was trying to use the plots2 folder on terminal it shows that required ruby version is not installed "ruby 2.4.4" .
so, now what i have to do ?

Thank you,
shridhi

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Mar 24, 2019

Hi @aggarwal19, thanks for highlighting this issue. You have to install ruby-2.4.4 which is specified in the Gemfile. Raising issue to fix the docs.

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Mar 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.