Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow button must be aligned in the middle #5051

Closed
divyabaid16 opened this Issue Mar 13, 2019 · 14 comments

Comments

Projects
None yet
4 participants
@divyabaid16
Copy link
Contributor

divyabaid16 commented Mar 13, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file $FILENAME in the $REPO repository (press the little pen Icon) and edit the line as shown below.

Selection_060

Update
The follow button must to aligned in the middle

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@luanafaustini

This comment has been minimized.

Copy link
Contributor

luanafaustini commented Mar 13, 2019

Hello, I would like to work on this issue. Is there anyone else working on it? Thanks!

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Mar 13, 2019

Hi @luanafaustini, go ahead!

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Mar 13, 2019

@divyabaid16 please add the link to the file which needs to be changed as it's a FTO. Thanks!

@luanafaustini

This comment has been minimized.

Copy link
Contributor

luanafaustini commented Mar 13, 2019

Thanks @gauravano I will be waiting for the link to start!

@divyabaid16

This comment has been minimized.

Copy link
Contributor Author

divyabaid16 commented Mar 14, 2019

@luanafaustini I will update the link by today.

@divyabaid16

This comment has been minimized.

Copy link
Contributor Author

divyabaid16 commented Mar 14, 2019

@luanafaustini
You need to change this line to

<li style="width: 100%;"><span id="tag_<%= tag.tid %>" class="label <%= label_name %>" style="cursor:pointer" data-toggle="popover" data-trigger="focus" data-count=0 data-placement="top" data-content="<p style='text-align:center;'><a href='/tag/<%= tag.name %>'><%= Tag.tagged_node_count(tag.name) || 0 %> notes</a> - <a href='/contributors/<%= tag.name %>'><%= Tag.contributors(tag.name).count %> people <br></a></p> <p style='text-align:center;font-size:12px;'><%if tag.description %><%= tag.description %> |<% end %> created by <a href='/profile/<%= tag.try(:author).try(:username) %>'><%= tag.try(:author).try(:username) %></a> <%= time_ago_in_words(Time.at(tag.date)) %> ago </p><div style='text-align:center;' class='text-center'><a href='/subscribe/tag/<%= tag.name %>' class='btn btn-primary'>Follow</a></div>" data-html="true" title="<%= tag.name %>">
@luanafaustini

This comment has been minimized.

Copy link
Contributor

luanafaustini commented Mar 14, 2019

Hello, thank you!

luanafaustini#1 (comment)
is this it?

@divyabaid16

This comment has been minimized.

Copy link
Contributor Author

divyabaid16 commented Mar 14, 2019

Yes @luanafaustini
Since this is an issue for first-timers-only to get familiar with the code base and the organization.

@luanafaustini

This comment has been minimized.

Copy link
Contributor

luanafaustini commented Mar 14, 2019

Hi, @divyabaid16 Thank you! I wasn't sure if I had submitted right. Would you like to assign me another task? Can I count this task as a contribution? How can I proceed with? I appreciate your help.

@divyabaid16

This comment has been minimized.

Copy link
Contributor Author

divyabaid16 commented Mar 14, 2019

@luanafaustini have you created the pull request?

@luanafaustini luanafaustini referenced this issue Mar 14, 2019

Merged

Update _tags.html.erb line 5 #1

0 of 5 tasks complete
@luanafaustini

This comment has been minimized.

Copy link
Contributor

luanafaustini commented Mar 14, 2019

Is the one that I mentioned on the comment above? Should I hit the Merge Pull Request button?

@divyabaid16

This comment has been minimized.

Copy link
Contributor Author

divyabaid16 commented Mar 14, 2019

Yes @luanafaustini
And then reference the pull request with this issue.

luanafaustini added a commit to luanafaustini/plots2 that referenced this issue Mar 14, 2019

Merge pull request #1 from luanafaustini/luanafaustini-patch-1 issue p…
…ubliclab#5051

Update _tags.html.erb line 5 to centralize the button
@luanafaustini

This comment has been minimized.

Copy link
Contributor

luanafaustini commented Mar 14, 2019

Thanks @divyabaid16 !

@divyabaid16

This comment has been minimized.

Copy link
Contributor Author

divyabaid16 commented Mar 14, 2019

@luanafaustini I think you have merged in your remote repo, you must send a pull request in this repository. There must be a button to compare and create a pull request. You must click that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.