Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer not sticking to the bottom of the screen on pages with little content on large displays #5059

Open
madeofhuman opened this Issue Mar 14, 2019 · 17 comments

Comments

Projects
None yet
4 participants
@madeofhuman
Copy link
Contributor

madeofhuman commented Mar 14, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
  • 📝 Update edit thw stylesheets folder to add styles that address this issue. You can check out this article for help.

Current Behavior
Visiting the following pages: https://publiclab.org/settings, https://publiclab.org/subscriptions (when you have little or no subscriptions), https://publiclab.org/subscriptions/digest (when you have little or no subscriptions), https://pubiclab.org/:user/likes (when you have little or no liked content) will show a footer that is pushed up and does not stick to the bottom of the page.

Screenshot 2019-03-14 at 12 23 12 AM
Screenshot 2019-03-14 at 12 23 29 AM
Screenshot 2019-03-14 at 12 23 36 AM
Screenshot 2019-03-14 at 12 23 42 AM

The above images are the only pages with little content I could find on production, but note that the behaviour will be replicated on any page with little content, as evidenced by this screenshot of a page on development:

Screenshot 2019-03-14 at 12 55 00 AM

Expected Behavior
The footer should stick to the bottom of the screen, no matter the height of the content.

Screenshot 2019-03-14 at 1 01 54 AM
Screenshot 2019-03-14 at 1 04 45 AM

  • 💾 Commit your changes
  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:
  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
  2. You can also edit files directly in your browser and open a pull request from there.
  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

@madeofhuman

This comment has been minimized.

Copy link
Contributor Author

madeofhuman commented Mar 14, 2019

@gauravano @cesswairimu @jywarren what do you think of this?

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Mar 14, 2019

@fabsar you can work on this one. Thanks!

@gauravano gauravano added the assigned label Mar 14, 2019

@fabsar

This comment has been minimized.

Copy link

fabsar commented Mar 14, 2019

thank you! will do that.

@shubhi2000

This comment has been minimized.

Copy link
Contributor

shubhi2000 commented Mar 16, 2019

@fabsar are you working on this issue?

@fabsar

This comment has been minimized.

Copy link

fabsar commented Mar 16, 2019

Yes, I am working on it.

@shubhi2000

This comment has been minimized.

Copy link
Contributor

shubhi2000 commented Mar 16, 2019

okay. All the best!

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Mar 16, 2019

hey @shubhi2000, if you are looking for first-timer issue, then we can add your name to the - #4963 list and can ping you when a new issue is opened?

@shubhi2000

This comment has been minimized.

Copy link
Contributor

shubhi2000 commented Mar 16, 2019

@fabsar

This comment has been minimized.

Copy link

fabsar commented Mar 16, 2019

thank you @shubhi2000 ! All the best to you too!!

@shubhi2000

This comment has been minimized.

Copy link
Contributor

shubhi2000 commented Mar 16, 2019

In the description of this issue, there is a link to stylesheets folder in the Update section. In that folder, many css files are given. Out of those, the file having footer styling is style.css .

@fabsar

This comment has been minimized.

Copy link

fabsar commented Mar 16, 2019

Oh Okay! Thank you :)

@fabsar

This comment has been minimized.

Copy link

fabsar commented Mar 17, 2019

I am unable to setup the environment for testing the code and the changes I made to it. I followed the instructions given for standard installation. I cannot get through with the 4th step. It says permission denied when I try to run the command gem install bundler. it gives the following error:ERROR: While executing gem ... (Gem::FilePermissionError)
You don't have write permissions for the /usr/local/bin directory.
Please help!

@fabsar

This comment has been minimized.

Copy link

fabsar commented Mar 17, 2019

I have made a pull request. kindly review it @gauravano . Thanks!

@fabsar fabsar referenced this issue Mar 17, 2019

Open

Update style.css fixes #5059 #5124

0 of 3 tasks complete
@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Mar 17, 2019

Hey @fabsar, try with sudo?

@fabsar

This comment has been minimized.

Copy link

fabsar commented Mar 18, 2019

Hey! I could run gem install bundler but bundle update isn't working now

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Mar 18, 2019

what output you're getting on running bundle update?

@fabsar

This comment has been minimized.

Copy link

fabsar commented Mar 19, 2019

It's working now. Thanks:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.