Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing up for a new account when viewing a user's profile page populates the sign up modal with the details of the currently-viewed user #5065

Open
madeofhuman opened this Issue Mar 14, 2019 · 14 comments

Comments

Projects
None yet
4 participants
@madeofhuman
Copy link
Contributor

madeofhuman commented Mar 14, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
  • 📝 Update _signupLoginModal.html.erb to clear the form fields when the modal is mounted.

Add modal.find("input[type=text], textarea").val(""); after line 46.

Current Behavior
Clicking the Sign up button on a user's profile page when signed out populates the sign up modal with the details of the user whose profile page you're on.

Screenshot 2019-03-14 at 1 36 27 PM

Screenshot 2019-03-14 at 1 41 15 PM

Screenshot 2019-03-14 at 1 42 17 PM

Expected Behavior
The sign up modal should initialise without any data in it.

Screenshot 2019-03-14 at 1 45 22 PM

  • 💾 Commit your changes
  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:
  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
  2. You can also edit files directly in your browser and open a pull request from there.
  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

@madeofhuman

This comment has been minimized.

Copy link
Contributor Author

madeofhuman commented Mar 14, 2019

@gauravano, @jywarren, @cesswairimu could you please review this. 😄 Thank you.

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Mar 15, 2019

Hey @madeofhuman, it's a privacy issue too 😮 as Email shouldn't be leaked. Let's put this on priority!!!

Also, as it's a FTO, please add code to solve it too. Thanks!

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Mar 15, 2019

@kuja24 you want to work in this one?

@kuja24

This comment has been minimized.

Copy link

kuja24 commented Mar 15, 2019

Yes I would like to work on it.

@mgroovyank

This comment has been minimized.

Copy link

mgroovyank commented Mar 16, 2019

@kuja24 Are you doing it?

@kuja24

This comment has been minimized.

Copy link

kuja24 commented Mar 16, 2019

yes I'm working on it

@kuja24

This comment has been minimized.

Copy link

kuja24 commented Mar 16, 2019

@gauravano @jywarren @cesswairimu
I went through the setup installations instructions in the README file. I have successfully cloned the repository but I'm not able to run the bundle command to set it up locally .Please help solving this error
image

@kuja24

This comment has been minimized.

Copy link

kuja24 commented Mar 16, 2019

I searched on the internet for the error.Do I need to install Ruby first?

@madeofhuman

This comment has been minimized.

Copy link
Contributor Author

madeofhuman commented Mar 16, 2019

@kuja24 run the command ruby -v and tell me what you see

@kuja24

This comment has been minimized.

Copy link

kuja24 commented Mar 16, 2019

The term 'ruby' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the
spelling of the name, or if a path was included, verify that the path is correct and try again.
This is what I get

@madeofhuman

This comment has been minimized.

Copy link
Contributor Author

madeofhuman commented Mar 16, 2019

That's okay. It means you do not have ruby installed on your system. Here's how we're going to install it on Windows 10: https://gorails.com/setup/windows/10

@kuja24

This comment has been minimized.

Copy link

kuja24 commented Mar 18, 2019

hey @gauravano @jywarren
I'm working on the issue. I will update you about the status tonight.

@kuja24

This comment has been minimized.

Copy link

kuja24 commented Mar 18, 2019

I installed windows subsystem for linux . I had added the feature and i am able to see bash in the search option but i'm not able to open it.
image
@madeofhuman please help

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Mar 18, 2019

Ah, I haven't run bash on windows,but may find some help here - #3840 also. And, if needed you can ask for cloud9 invite from us. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.