Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor nids in tag model #5215

Open
cesswairimu opened this issue Mar 21, 2019 · 9 comments

Comments

Projects
None yet
5 participants
@cesswairimu
Copy link
Collaborator

commented Mar 21, 2019

馃 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

馃搵 Step by Step

  • 馃檵 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

Problem:

I just extractes tids and nids to methods in the tag model https://github.com/publiclab/plots2/blob/master/app/models/tag.rb#L403-L409

馃摑 Update:

We want to remove wherever else they are defined in the model so that they can use the new methods.

Lets remove this line

After changing run the tests and make sure we didn't break anything

  • 馃捑 Commit your changes

  • 馃攢 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 馃弫 Done Ask in comments for a review :)

馃 Questions?

Leave a comment below!

@cesswairimu

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 21, 2019

@techchic here you go

@techchic

This comment has been minimized.

Copy link

commented Mar 21, 2019

Great! Thanks

@edwd42

This comment has been minimized.

Copy link

commented Mar 21, 2019

Hi cesswairimu. I am new to open source and public lab. I'm going to attempt this issue. Looks easy, but not sure what will happen when I click commit. Also, not sure where or how to run the tests. Guess I'll find out soon enough 馃槄

edwd42 added a commit to edwd42/plots2 that referenced this issue Mar 21, 2019

Update tag.rb
Step by Step instructions in Refactor nids in tag model publiclab#5215:
We want to remove wherever else they are defined in the model so that they can use the new methods.
Lets remove this line
    https://github.com/publiclab/plots2/blob/master/app/models/tag.rb#L198-L199
@techchic

This comment has been minimized.

Copy link

commented Mar 21, 2019

Hey @edwd42 I am currently working on this.

@cesswairimu

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 21, 2019

Hi @edwd42 will add your name for to a list of people looking for ftos pretty soon you should get an issue. and don't worry we are here to help. 馃槃 Thanks

@edwd42

This comment has been minimized.

Copy link

commented Mar 21, 2019

oh hey sorry techchic. didn't see that.

@Michaellin250

This comment has been minimized.

Copy link

commented Mar 27, 2019

Is this issue still open?

@gauravano

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

@techchic are you working on this one. If yes, can you please tag this issue in your PR. Thanks!

@gauravano

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

hey @Michaellin250, we can add your name to the #4963 if you like? Or, you can go through issues https://github.com/publiclab/plots2/issues/ and claim the one you find interesting. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.