Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change styling and wording of our "Tags" sidebar #5295

Open
first-timers bot opened this issue Mar 28, 2019 · 4 comments

Comments

Projects
None yet
4 participants
@first-timers
Copy link

commented Mar 28, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file app/views/tag/_tagging.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

We're going to edit the code for the template of the wiki pages, for example this one: https://publiclab.org/wiki/website

Here's a screenshot of how they currently look:

image

We want to adjust the size, color, and spacing of the title and subtitle.

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -2,12 +2,12 @@
 
 <!-- This is the sidebar tagging display, also renders Subscribe button for multiple subscription -->
 <div>
-  <h1 style="display: inline-block; margin-right: 20px;">Tags</h1>
+  <h2 style="display: inline-block; margin-right: 20px;">Tags</h2>
   <% if @node && !@node.node_tags.empty? && ((current_user && @node.liked_by(current_user.uid)) || !current_user) %>
     <%= render partial: 'tag/subscribe_button', locals:{tags: @node.node_tags} %>
   <% end %>
 </div>
-<em class="italics"><a href="/tags">Tags</a> organize our knowledge base. Click to learn more or subscribe to a topic.</em>
+<p style="font-style:italic;color:#aaa;"><small><a href="/tags">Tags</a> organize our knowledge base. Click one to learn more or subscribe to a topic.</small></p>
 
 
 <% if @node %>
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

This one is for you, @jtmims !

@Swati-rachamalla

This comment has been minimized.

Copy link

commented Mar 29, 2019

hi..i am interested to solve the issue. but can you help me with starting of the contribution

@gauravano

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

Hi @Swati-rachamalla, this issue is already assigned but we would love to have your help with other issues. You can comment here- #4963 to get yourself issue assigned or go through https://github.com/publiclab/plots2/issues/ and claim one which is not assigned/claimed to/by another contributor yet.

Thanks!

@gauravano gauravano added the assigned label Mar 29, 2019

@CoderJolly CoderJolly referenced a pull request that will close this issue May 9, 2019

Open

Update _tagging.html.erb #5698

0 of 5 tasks complete
@CoderJolly

This comment has been minimized.

Copy link
Member

commented May 9, 2019

Generated PR #5698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.