Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Close the "Subscribe+" popover by clicking anywhere on the screen #5383
Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.
If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!
We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you
If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!
Attach a click event to the document body excluding the "#mypopcontent" which can be found by getElementById(), which closes the popover.
If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.
If this happens to you, don't sweat it! Grab another open issue.
Is someone else already working on this?
Hi @ckairen, some parts of publiclab.org like footer, header of tags page, etc are stored in the database. We call them features, like here https://github.com/publiclab/plots2/blob/app/views/sidebar/_user.html.erb#L5 and there are many. So, you can also create a feature by logging in as admin and then going over at /features page and creat a feature with same title as name in the code.
Also, publiclab.org is the production environment so facebook share, etc are extra there.
If you want to test a particular section, feel free to ask, maybe I or @publiclab/plots2-reviewers can help you. Thanks!