Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit extra long wiki titles #5426

Open
GettyOrawo opened this issue Apr 9, 2019 · 5 comments

Comments

Projects
None yet
4 participants
@GettyOrawo
Copy link
Contributor

commented Apr 9, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

There is a small section of wiki title creation that hasn't been taken care of. A wiki title needs to be as brief as any other title. However there are no limits to this when creating a wiki. http://localhost:3000/wiki Our title can, in worst case, look like this:

long-wiki

We can add an HTML attribute maxlength="" to the title field and set it equal to the number of characters you are limiting to. In our case we can limit title characters to 50 or 60. Your choice.

The target file and line number is:
https://github.com/publiclab/plots2/blob/master/app/views/wiki/edit.html.erb#L61

Add the attribute to this input tag and test if it is working. Note that only admins can create new Wikis so you will have to log in as an admin if you want to see this play on your local server. All the best! 😄

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@GettyOrawo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

@publiclab/reviewers

@HarshKhandeparkar

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

@GettyOrawo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

Thank you 🙂

@jeremypurser

This comment has been minimized.

Copy link

commented Apr 9, 2019

Hi! Could I claim this?

@GettyOrawo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

sure @jeremypurser ! 😄

@jeremypurser jeremypurser referenced a pull request that will close this issue Apr 11, 2019

Open

Add character limit to wiki titles #5460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.