Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add css to 'Subscribe to answer questions' button #5462

Open
ananyaarun opened this Issue Apr 11, 2019 · 9 comments

Comments

Projects
None yet
3 participants
@ananyaarun
Copy link
Member

ananyaarun commented Apr 11, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file _question.html.erb in the plots2 repository.
    Use the css of the 'Ask a question' button for the 'Subscribe to answer' button.
    Updated look:

newlook

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@ananyaarun

This comment has been minimized.

Copy link
Member Author

ananyaarun commented Apr 11, 2019

Another issue based on the discussion here #5180

@johnmidavis

This comment has been minimized.

Copy link

johnmidavis commented Apr 12, 2019

Forked and branched and fixed.
I am still struggling with test documentation.

@ananyaarun

This comment has been minimized.

Copy link
Member Author

ananyaarun commented Apr 12, 2019

Which test documentation ? Have you been able to install public Labs locally ? feel free to ask any question/help @johnmidavis :)

@johnmidavis

This comment has been minimized.

Copy link

johnmidavis commented Apr 12, 2019

I have successfully installed locally and am able to log in and do ad hoc testing.

I am working through TESTING.md:

There is an issue running 'rails test -d' repeatedly - the database is not reset. There is a rake task 'test:db' which does clean the database so this is obviously known. I can run db:drop and db:setup every time for now.

Also errors related to SUBSTRING_INDEX which should go away if I follow the instructions about running with MySQL. I have MySql set up and running in docker locally, so I will follow up after I do that.

I have seen errors about connecting to Redis on 127.0.0.1 - I am not running Redis on my machine - don't know if I'm missing something or this test is supposed to be skipped when not is staging or Travis or something.

@johnmidavis

This comment has been minimized.

Copy link

johnmidavis commented Apr 12, 2019

rake db:setup dies here

-- create_table("impressions", {:force=>:cascade})
rake aborted!
ActiveRecord::StatementInvalid: Mysql2::Error: Specified key was too long; max key length is 3072 bytes: CREATE TABLE impressions (id bigint NOT NULL AUTO_INCREMENT PRIMARY KEY, impressionable_type varchar(255), `impressionable...
dbsetup.err.txt

@ananyaarun

This comment has been minimized.

Copy link
Member Author

ananyaarun commented Apr 13, 2019

@gauravano any idea why the above error is happening ?

@johnmidavis

This comment has been minimized.

Copy link

johnmidavis commented Apr 13, 2019

The bug is related to a style applied to one button - defined in erb versus another where the html is in the locale yml file, with a different style.

As for the database error just above, which is preventing me from running Test and Dev against MySql rather than SQLite, to hopefully pass test before creating a pull request: db:setup fails because of key length error. MySQL gives a more instructive error than MariaDB :

ActiveRecord::StatementInvalid: Mysql2::Error: BLOB/TEXT column 'params' used in key specification without a key length: 

which is presumably related to;

add_index :impressions, [:impressionable_type, :impressionable_id, :params], :name => "poly_params_request_index", :unique => false, :length => { :params => 255 }

but we are specifying ":length => { :params => 255 }"

@johnmidavis

This comment has been minimized.

Copy link

johnmidavis commented Apr 13, 2019

BEFORE
Screenshot-before

AFTER
Screenshot-after

@johnmidavis johnmidavis referenced a pull request that will close this issue Apr 14, 2019

Open

Add css to 'Subscribe to answer questions' button #5462 #5476

5 of 5 tasks complete
@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Apr 15, 2019

Hi @johnmidavis, sorry for the inconvenience, we are having discussions to decide on database - #4896. We would love to have your thoughts there too.

Regarding the failure of tests, you can ignore them and create a PR. But, if you're facing error in setup too, like in running rake db:setup, then we can discuss and try to solve that?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.