Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cursor to pointer on choosing main image #5516

Closed
divyabaid16 opened this issue Apr 18, 2019 · 10 comments

Comments

Projects
None yet
5 participants
@divyabaid16
Copy link
Contributor

commented Apr 18, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update
    In https://publiclab.org/wiki/new
    Change here:
    Peek 2019-04-18 12-39

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@CleverFool77

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Hi @divyabaid16
Can you point out the relevant changes required.
Thanks !!!

@ValeriaCobianISW

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

Hi, Is somebody working on this issue? I would like to contribute 👍

@michelmarechal

This comment has been minimized.

Copy link

commented Apr 23, 2019

Hey! I'm a first timer in open source and I'd love to contribute to this issue.

@gauravano

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

Hi @ValeriaCobianISW, sorry for late reply. Sure, go ahead with the issue. Thanks!

@gauravano

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

Hi @michelmarechal, we would love to have your help too, you can find more FTO issues at https://code.publiclab.org/#r=all, and in case you don't see any issue unclaimed then feel free to comment at #4963 and we'll create a new one for you.

Thanks!

@gauravano gauravano added the claimed label Apr 23, 2019

@ValeriaCobianISW

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

Thank you @gauravano , I'm going to resolve this issue 😄

@michelmarechal

This comment has been minimized.

Copy link

commented Apr 24, 2019

Sure thing @guravano. I'll do that :)

ValeriaCobianISW added a commit to ValeriaCobianISW/plots2 that referenced this issue Apr 24, 2019

ValeriaCobianISW added a commit to ValeriaCobianISW/plots2 that referenced this issue Apr 24, 2019

ValeriaCobianISW added a commit to ValeriaCobianISW/plots2 that referenced this issue Apr 24, 2019

ValeriaCobianISW added a commit to ValeriaCobianISW/plots2 that referenced this issue Apr 24, 2019

@ValeriaCobianISW

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

This issue is done @divyabaid16 @gauravano ,asking for feedback :D

@gauravano

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

Hey @ValeriaCobianISW, we allow only one FTO per contributor but as you have done the work, so we'll consider it but please don't claim/solve anymore FTO issues. Thanks!

@ValeriaCobianISW

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

Sure @gauravano, sorry for this, I thought that I could contribute again with FTO 😀
Thanks!

ValeriaCobianISW added a commit to ValeriaCobianISW/plots2 that referenced this issue Apr 24, 2019

gauravano added a commit that referenced this issue May 20, 2019

Fix #5516: Changed cursor to pointer on choosing main image. (#5611)
* Fix #5516: Changed cursor to pointer on choosing main image

* Fix#5516 Changed cursor to pointer in choose file.

* Update app/views/editor/_main_image.html.erb

Styles was updated.

Co-Authored-By: ValeriaCobianISW <valeriacobianisw@gmail.com>

* Update app/views/editor/_main_image.html.erb

Co-Authored-By: Gaurav Sachdeva <sachdeva.gaurav1997@gmail.com>

* Deleted css code about cursor pointer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.