Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link "Public Lab" on navbar to the home page instead of dashboard #5629

Open
gautamig54 opened this issue Apr 27, 2019 · 6 comments

Comments

Projects
None yet
4 participants
@gautamig54
Copy link
Contributor

commented Apr 27, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update: Currently, "Public Lab" on the navbar links the user to the root_path i.e, dashboard. Instead it should link to the https://publiclab.org/home page as we already have a separate dashboard link on the navbar.
    Update apps/views/layouts/_header.html.erb in the plots2 repository.
    Change href="<%= root_path %>" to href="/home" on line 14

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

@elzatch4219

This comment has been minimized.

Copy link

commented Apr 27, 2019

Is somebody else working on this

@gautamig54

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2019

@elzatch4219 It is still not claimed. You can go ahead with this one!

@IshaGupta18

This comment has been minimized.

Copy link
Collaborator

commented Apr 28, 2019

Please go ahead @elzatch4219 and do let us know if you're stuck!

@IshaGupta18 IshaGupta18 added the HTML label Apr 28, 2019

@gautamig54 gautamig54 changed the title Link "Public Lab" on header to the home page instead of dashboard Link "Public Lab" on navbar to the home page instead of dashboard Apr 28, 2019

@CoderJolly

This comment has been minimized.

Copy link
Member

commented May 8, 2019

Still taken ?

@CoderJolly CoderJolly referenced a pull request that will close this issue May 8, 2019

Open

Update _header.html.erb #5686

2 of 5 tasks complete
@CoderJolly

This comment has been minimized.

Copy link
Member

commented May 8, 2019

Generated PR #5686

@gautamig54

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

@CoderJolly Great work! Welcome to PL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.