Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rubocop performance deprecation warning #5795

Open
cesswairimu opened this issue May 26, 2019 · 5 comments

Comments

Projects
None yet
5 participants
@cesswairimu
Copy link
Collaborator

commented May 26, 2019

馃 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

馃搵 Step by Step

  • 馃檵 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

Problem:

Performance cops have been removed from RuboCop 0.68

馃摑 Update:

Put this in Gemfile.

gem 'rubocop-performance'

Then add this in .rubocop.yml.

require: rubocop-performance

After changing run bundle install

  • 馃捑 Commit your changes

  • 馃攢 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 馃弫 Done Ask in comments for a review :)

馃 Questions?

Leave a comment below!

@kodyclemens

This comment has been minimized.

Copy link

commented May 27, 2019

I'd be happy to tackle this issue.

@kodyclemens kodyclemens referenced this issue May 27, 2019

Closed

Fix Rubocop performance deprecation warning #5796

6 of 6 tasks complete
@Esh08

This comment has been minimized.

Copy link

commented May 27, 2019

Hey, I'm a first time user of GitHub and would love to know if I can assist you in any way? @kodyclemens

@kodyclemens

This comment has been minimized.

Copy link

commented May 28, 2019

@Esh08 Unfortunately I think this issue may have to wait as Codeclimate does not yet support the new gem, which is resulting in failing tests.

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

Thanks! That's too bad - maybe we can mark the PR with that and then merge it hopefully down the road once it is supported? Thank you for your help!!!

@alaxalves

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

@kodyclemens @jywarren CodeClimate currently only supports rubocop ~> 0.52.0. We had this same issue with mapknitter at publiclab/mapknitter#547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.